-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding and enabling new languages from Crowdin #245
Conversation
You probably should change all urls like |
Isn't there a way to automatically update all translations with new strings? |
I don't think so, as far as I know.... |
@yeager you probably should make the four edits I suggested up here |
I believe I have added Swedish to all aspects of the UI. Code compiles OK and all works |
@nicola02nb ping :) |
Excuse me, why ping? |
Oh, I thought you could approve this |
Nope, as far as I know only @GreemDev can... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this old NO translation due to newer in #338
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The locales system has undergone basically an entire refactoring, which makes this PR not able to be merged unless it is redone with the new changes.
I apologize for this inconvenience, I hope it is made up by the fact that the new system is cleaner, and should be easier to translate.
You can add new languages by opening up the locales.json
file (where the Locales
folder containing the various JSONs was previously) and adding the short language code (that previously was the file's name) to the Languages
list at the top.
Once that's done you open up the project in an IDE (Visual Studio Community & Rider both work, VS Code might) and do a "rebuild" specifically. The locale file validator only runs on rebuild. That will go through each locale key and add an empty string for the languages that are missing, to simplify adding a new language.
If you want any assistance just @me Yeager. i would be happy to help to reduce the workload abit for you. |
Nah, I'm good. Will take a look at this right now |
All done now. Compiles good and works good. Awesome, guys! 41>------ Rebuild All started: Project: Ryujinx.Headless.SDL2, Configuration: Debug x64 ------ |
No description provided.