Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding and enabling new languages from Crowdin #245

Closed
wants to merge 0 commits into from

Conversation

yeager
Copy link
Contributor

@yeager yeager commented Nov 14, 2024

No description provided.

@github-actions github-actions bot added the gui Affects the Avalonia UI or translations. label Nov 14, 2024
@nicola02nb
Copy link
Contributor

You probably should change all urls like https://ryujinx.org/ to https://ryujinx.app/download

@yeager
Copy link
Contributor Author

yeager commented Nov 15, 2024

Isn't there a way to automatically update all translations with new strings?

@nicola02nb
Copy link
Contributor

nicola02nb commented Nov 15, 2024

I don't think so, as far as I know....
If your question is related of what I said previously, you have only 5 urls to edit... so just change them manually and comit.

@nicola02nb
Copy link
Contributor

@yeager you probably should make the four edits I suggested up here

@yeager
Copy link
Contributor Author

yeager commented Nov 23, 2024

I believe I have added Swedish to all aspects of the UI. Code compiles OK and all works

@yeager
Copy link
Contributor Author

yeager commented Nov 26, 2024

@nicola02nb ping :)

@nicola02nb
Copy link
Contributor

Excuse me, why ping?

@yeager
Copy link
Contributor Author

yeager commented Nov 26, 2024

Oh, I thought you could approve this

@nicola02nb
Copy link
Contributor

Nope, as far as I know only @GreemDev can...

src/Ryujinx.HLE/HOS/SystemState/KeyboardLayout.cs Outdated Show resolved Hide resolved
src/Ryujinx/Assets/Locales/sv_SE.json Outdated Show resolved Hide resolved
Copy link
Contributor Author

@yeager yeager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this old NO translation due to newer in #338

Copy link
Member

@GreemDev GreemDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The locales system has undergone basically an entire refactoring, which makes this PR not able to be merged unless it is redone with the new changes.

I apologize for this inconvenience, I hope it is made up by the fact that the new system is cleaner, and should be easier to translate.

You can add new languages by opening up the locales.json file (where the Locales folder containing the various JSONs was previously) and adding the short language code (that previously was the file's name) to the Languages list at the top.
Once that's done you open up the project in an IDE (Visual Studio Community & Rider both work, VS Code might) and do a "rebuild" specifically. The locale file validator only runs on rebuild. That will go through each locale key and add an empty string for the languages that are missing, to simplify adding a new language.

@Daenorth
Copy link
Contributor

If you want any assistance just @me Yeager. i would be happy to help to reduce the workload abit for you.

@yeager
Copy link
Contributor Author

yeager commented Dec 24, 2024

Nah, I'm good. Will take a look at this right now

@yeager
Copy link
Contributor Author

yeager commented Dec 25, 2024

All done now.

Compiles good and works good. Awesome, guys!

41>------ Rebuild All started: Project: Ryujinx.Headless.SDL2, Configuration: Debug x64 ------
38>Ryujinx.Tests -> C:\Users\windo\Downloads\dump\Ryujinx\src\Ryujinx.Tests\bin\x64\Debug\net9.0\Ryujinx.Tests.dll
41>Ryujinx.Headless.SDL2 -> C:\Users\windo\Downloads\dump\Ryujinx\src\Ryujinx.Headless.SDL2\bin\x64\Debug\net9.0\Ryujinx.Headless.SDL2.dll
40>Ryujinx -> C:\Users\windo\Downloads\dump\Ryujinx\src\Ryujinx\bin\x64\Debug\net9.0\Ryujinx.dll
========== Rebuild All: 41 succeeded, 0 failed, 0 skipped ==========
========== Rebuild completed at 10:39 and took 09,893 seconds ==========

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gui Affects the Avalonia UI or translations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants