ignore macos attribute files #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
audio
GreemDev
added
infra
Merged
GreemDev
pushed a commit
that referenced
this pull request
Dec 19, 2024
marco-carvalho
pushed a commit
to marco-carvalho/Ryujinx
that referenced
this pull request
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving files under Mac OS Sequoia to an external drive not formatted with APFS, a dot underscore attribute file is created for modified files, MSBUILD picks these up and fails the build with error:
CSC : error CS2015: '/Volumes/MACBOOK/EXEC/Ryujinx/GitHub/Ryujinx/src/Ryujinx/._Updater.cs' is a binary file instead of a text file [/Volumes/MACBOOK/EXEC/Ryujinx/GitHub/Ryujinx/src/Ryujinx/Ryujinx.csproj]
Adding the following line to the csproj files inside the project group will stop these files from attempted to being built:
$(DefaultItemExcludes);._*
Also suggest that we exclude these files from GIT as well by adding this line to the .gitignore file:
._*
This is a PR to fix this issue so that the MacOS attribute files are ignored both by the build and by git to make development easier when working with external drives.
This fixes issue #301