-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a new window for shortcut configuration #607
Conversation
Added new arguments for shortcuts. When starting a game with arguments, a separate independent setting will be used
I feel like this functionality would be rendered kinda redundant once we have per-game configurations. |
protected override void OnClosing(WindowClosingEventArgs e) | ||
{ | ||
|
||
foreach (IGamepad gamepad in RyujinxApp.MainWindow.InputManager.GamepadDriver.GetGamepads()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the LED clearing logic is needed here
); | ||
} | ||
|
||
private string SetArguments() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop the brace into a new line; rename the method to GetArguments
; it is returning a value and not setting anything
Download the artifacts for this pull request: |
There is currently no separate configuration for games, but this method at least allows you to configure shortcuts separately, so it might not be superfluous now. |
I couldn't figure out why the local version worked without problems, but the one compiled on github didn't work properly. I figured it out, this is a test release version https://github.com/Goodfeat/Ryujinx_alt/releases/download/1.2.59/ryujinx-1.2.59-win_x64.zip |
Added a window with settings for shortcuts. When creating a shortcut, arguments of those settings that were changed in this window will be added.
Added new arguments for shortcuts that the shortcut creation window uses.
When starting a game with arguments, a separate configuration is used (based on the global configuration), but does not affect it in any way
001.mp4