Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new window for shortcut configuration #607

Closed
wants to merge 22 commits into from

Conversation

Goodfeat
Copy link
Contributor

@Goodfeat Goodfeat commented Feb 1, 2025

Added a window with settings for shortcuts. When creating a shortcut, arguments of those settings that were changed in this window will be added.
Added new arguments for shortcuts that the shortcut creation window uses.
When starting a game with arguments, a separate configuration is used (based on the global configuration), but does not affect it in any way

image

001.mp4

@github-actions github-actions bot added the gui Affects the Avalonia UI or translations. label Feb 1, 2025
@GreemDev
Copy link
Member

GreemDev commented Feb 1, 2025

I feel like this functionality would be rendered kinda redundant once we have per-game configurations.

protected override void OnClosing(WindowClosingEventArgs e)
{

foreach (IGamepad gamepad in RyujinxApp.MainWindow.InputManager.GamepadDriver.GetGamepads())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the LED clearing logic is needed here

);
}

private string SetArguments() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

@Goodfeat
Copy link
Contributor Author

Goodfeat commented Feb 1, 2025

I feel like this functionality would be rendered kinda redundant once we have per-game configurations.

There is currently no separate configuration for games, but this method at least allows you to configure shortcuts separately, so it might not be superfluous now.

@Goodfeat Goodfeat requested a review from GreemDev February 1, 2025 07:38
@Goodfeat
Copy link
Contributor Author

Goodfeat commented Feb 1, 2025

image
this pull request seems to require changes to the workflow as the workflow does not have the required path and simply replicates the original path

@Goodfeat
Copy link
Contributor Author

Goodfeat commented Feb 1, 2025

I couldn't figure out why the local version worked without problems, but the one compiled on github didn't work properly. I figured it out, this is a test release version

https://github.com/Goodfeat/Ryujinx_alt/releases/download/1.2.59/ryujinx-1.2.59-win_x64.zip

@Goodfeat Goodfeat marked this pull request as draft February 3, 2025 13:29
@Goodfeat Goodfeat closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gui Affects the Avalonia UI or translations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants