Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jit Cache Regions! #615

Merged
merged 21 commits into from
Feb 10, 2025
Merged

Add Jit Cache Regions! #615

merged 21 commits into from
Feb 10, 2025

Conversation

FluffyOMC
Copy link
Contributor

@FluffyOMC FluffyOMC commented Feb 3, 2025

Instead of one big 2048MB JIT Cache that'd crash the emulator when maxed out, we now have it where we add 256MB JIT Cache regions when needed, helping reduce allocated memory where games don't use the JIT cache for it, and helping bigger games that DO need JIT cache bigger than 2048MB!

image
(SSBU goes past the 2048MB JIT Cache limit that would normally crash Ryujinx ^)

Also I added a BSD socket that Baba is You's networking for downloading custom levels uses.

@github-actions github-actions bot added cpu An issue with ARMeilleure, the JIT, or Hypervisor horizon Affects the Horizon OS HLE components. labels Feb 3, 2025
@LotP1
Copy link
Contributor

LotP1 commented Feb 3, 2025

I'd be interested in seeing if this has any performance impact.
I'll do some testing in TotK later.

@MrCuriowls
Copy link

I think you should make regions size editable from ui. A bigger size would make less allocation operations hence less disk resources usage.

@LotP1
Copy link
Contributor

LotP1 commented Feb 3, 2025

it doesn't impact disk at all, it's all in ram

@FluffyOMC
Copy link
Contributor Author

@MrCuriowls As LotP1 said, this is the ram cache that slowly gets filled by a game running different/new functions.

@LotP1 As for performance... Maybe a very tiny difference due to it having to look through a smaller area of RAM for cached functions... But this change mainly just reduces ram usage.

@FluffyOMC
Copy link
Contributor Author

I even tried for fun 512kb region sizes. I got up to 1436 regions in Smash but no performance drops or lag when making the new regions :P

@MrCuriowls
Copy link

I hope these commits fixes Mario & Luigi Brothership Crash

@LotP1
Copy link
Contributor

LotP1 commented Feb 4, 2025

@MrCuriowls this is unrelated to the brothership crash

@GreemDev
Copy link
Member

GreemDev commented Feb 4, 2025

I hope these commits fixes Mario & Luigi Brothership Crash

Please stop with the copium, if the game was being fixed the PR description would say it, all you're doing is giving people false hope so they can say "I thought brothership was fixed" when they find out it's still as broken as it was before.

@GreemDev GreemDev merged commit faacec9 into Ryubing:master Feb 10, 2025
10 checks passed
@GreemDev GreemDev mentioned this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpu An issue with ARMeilleure, the JIT, or Hypervisor horizon Affects the Horizon OS HLE components.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants