-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jit Cache Regions! #615
Conversation
Download the artifacts for this pull request: |
I'd be interested in seeing if this has any performance impact. |
I think you should make regions size editable from ui. A bigger size would make less allocation operations hence less disk resources usage. |
it doesn't impact disk at all, it's all in ram |
@MrCuriowls As LotP1 said, this is the ram cache that slowly gets filled by a game running different/new functions. @LotP1 As for performance... Maybe a very tiny difference due to it having to look through a smaller area of RAM for cached functions... But this change mainly just reduces ram usage. |
I even tried for fun 512kb region sizes. I got up to 1436 regions in Smash but no performance drops or lag when making the new regions :P |
I hope these commits fixes Mario & Luigi Brothership Crash |
@MrCuriowls this is unrelated to the brothership crash |
Please stop with the copium, if the game was being fixed the PR description would say it, all you're doing is giving people false hope so they can say "I thought brothership was fixed" when they find out it's still as broken as it was before. |
Instead of one big 2048MB JIT Cache that'd crash the emulator when maxed out, we now have it where we add 256MB JIT Cache regions when needed, helping reduce allocated memory where games don't use the JIT cache for it, and helping bigger games that DO need JIT cache bigger than 2048MB!
(SSBU goes past the 2048MB JIT Cache limit that would normally crash Ryujinx ^)
Also I added a BSD socket that Baba is You's networking for downloading custom levels uses.