-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temp fix - chokidar #486
Temp fix - chokidar #486
Conversation
…de the package json so that webpack uses 4.44.6 which brings in watchpack and that uses the latest version of chokidar 3
@isaacabraham - I was able to confirm our fix from this afternoon. Let me know if you need anything else :) |
Fixes #462 |
@theimowski you ok with this? |
Is this maybe fixed by #485? |
This is indeed fixed by the webpack update. I think the plan was to fast track in this fix whilst we work on getting #485 merged |
yeah I'd say let's get #485 to work, don't think we need to rush with this workaround |
can we close it now? |
The above problem is not resolved in 3.1.1 is this correct? Got it working upgrading webpack and copying dependencies from the latest package.json from the full safe-stack template. |
@halcwb Yes, that looks to be the case. @theimowski what's your thoughts on release e.g. SAFE 3.2 (or 3.5?) which upgrades this? |
I think we can close this now, especially since #485 has been merged in. |
yeah we should release new version soon (quite a few changes) but I think it makes sense to include .net 60 upgrade #494 |
Fixed by #472 |
On the minimal template if you have a specific version of node(14.17.2/npm(7.19.1) you get the below error
throw new Error( ^ Error: No version of chokidar is available. Tried chokidar@2 and chokidar@3. You could try to manually install any chokidar version. chokidar@3: Error: Cannot find module 'chokidar'
But the full template is fine, this is because in the full template various dependencies (sass) use the latest version of chokidar and webpack is using 4.44.6
I've copied over the same versions of webpack/webpack-cli/webpack-dev-server from the full to the minimal as they should always be in sync and re made the lock file.
This has fixed the bug :)