Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide project / output / cache files from VS Code #625

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Conversation

jwthomson
Copy link
Contributor

@jwthomson jwthomson commented Aug 16, 2024

Relates to #617.

After some discussion we thought that ignoring some files is a good idea, but hiding files as a tree under other files could be confusing. Most of the files which were proposed for hiding in a tree were config files which are more likely to need to be edited so we opted not to nest them.

@Larocceau Larocceau self-requested a review August 16, 2024 13:51
@isaacabraham
Copy link
Member

@jwthomson is this good to go?

Copy link
Contributor

@Larocceau Larocceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check if this can be done with the gitignore instead

@Larocceau
Copy link
Contributor

@isaacabraham, no; we later decided to see if we can use the gitignore for this. I redacted my approval

@jwthomson
Copy link
Contributor Author

There were some files which are ignored in the .gitignore which someone may wish to edit from within VS code, e.g. user-specific settings files. So I opted not to persue using the .gitignore file as a basis for what files should be hidden.

@jwthomson jwthomson merged commit 1f1c37a into master Aug 30, 2024
1 check passed
@jwthomson jwthomson deleted the exclude-files branch August 30, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants