Include PHP 8.4 test coverage #600
Merged
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
commented
Nov 8, 2024
blizzz
commented
- also fixes deprecations on implicit null
- also fixes deprecations on implicit null Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
|
@pitbulk mind re-running the failing test? It looks like a glitch with setup-php to me, especially since similar tests go through elsewhere. |
|
@pitbulk it was an upstream issue in setup-php and is now fixed in one of its utility scripts, which is being fetched from git: shivammathur/setup-php#882 |
|
@pitbulk thanks - green now 🥳 Could we have a 8.4 compat release with this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.