This repository has been archived by the owner on Jan 5, 2022. It is now read-only.
Ignore artifacts of previously cancelled test runs #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florian-richter
requested review from
FrankEssenberger,
marikaner and
mr-flannery
florian-richter
changed the title
marikaner
approved these changes
Dec 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Artifacts of previously cancelled test runs could pollute the
test/folder leading to failing tests (as the generated code may contain tests that would be picked up.Also the tests were very slow. Some of that is difficult to avoid but currently we installed the generated dependencies for each of the init tests which took about 3 min. A new flag allows to skip this and shortens the test cycle by about those 3 min. The first init test still installs dependencies as it verifies that the scaffold is functioning and therefore needs the dependencies to be installed.
Checklist
Further Comments
If the changes are complex, please discuss what alternatives you have evaluated and why you picked this particular solution. Please make sure to highlight any trade-offs that we should know about.