Skip to content
This repository has been archived by the owner on Jan 5, 2022. It is now read-only.

Warnings in success msg #43

Merged
merged 5 commits into from
Jan 8, 2020
Merged

Warnings in success msg #43

merged 5 commits into from
Jan 8, 2020

Conversation

florian-richter
Copy link
Contributor

@florian-richter florian-richter commented Jan 8, 2020 •
edited
Loading

Proposed Changes

Since we are using listr, we can't use cli-ux to output warnings as the list is displayed. Therefore the warnings are now collected and displayed in the "success" message at the end.

Checklist

  • I have added or adjusted tests that prove my fix is effective or that my feature works
  • I have added or adjusted documentation

marikaner
marikaner approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@marikaner marikaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments

src/utils/warnings.ts Outdated Show resolved Hide resolved
src/utils/jest-config.ts Show resolved Hide resolved
@florian-richter florian-richter merged commit 369694f into master Jan 8, 2020
@florian-richter florian-richter deleted the warnings-in-success-msg branch January 8, 2020 16:19
@florian-richter florian-richter mentioned this pull request Jan 9, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marikaner marikaner marikaner approved these changes

@mr-flannery mr-flannery Awaiting requested review from mr-flannery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florian-richter @marikaner