Skip to content
This repository has been archived by the owner on Jan 5, 2022. It is now read-only.

Install generator only if needed #52

Merged
merged 6 commits into from
Jan 17, 2020
Merged

Conversation

florian-richter
Copy link
Contributor

@florian-richter florian-richter commented Jan 17, 2020

Proposed Changes

The CLI can currently not be installed unless the @SAP:registry is configured as the generator is a necessary dependency. This removes the dependency and installs the generator globally if needed.

Checklist

  • I have added or adjusted tests that prove my fix is effective or that my feature works
  • I have added or adjusted documentation

Copy link
Contributor

@mr-flannery mr-flannery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, as a temporary fix this should be okay. Maybe make more explicit what's happening when you ask whether the generator should be installed globally.

@florian-richter florian-richter merged commit c2e7d7c into master Jan 17, 2020
@florian-richter florian-richter deleted the Remove-generator-dep branch January 17, 2020 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants