Download the cx-server from github.com #9
Conversation
# Conflicts: # src/commands/add-cx-server.ts # src/commands/init.ts
src/utils/templates.ts
Outdated
| } | ||
|
|
||
| function copyLocal(sourcePath: string, targetFolder: string, fileName: string, options: { [key: string]: any }) { | ||
| return new Promise((resolve, reject) => { |
There was a problem hiding this comment.
nitpick: you could save one level of indentation across the whole function by returning Promise.resolve() or Promise.reject(e), respectively. Personally I find this easier to read.
There was a problem hiding this comment.
Can you be more explicit? I tried to do it that way but I couldn't figure out how. But maybe I am missing something obvious...
src/commands/add-cx-server.ts
Outdated
| const files = [ | ||
| { | ||
| sourcePath: new URL('cx-server', githubPrefix), | ||
| targetFolder: path.resolve(flags.projectDir, 'cx-server'), | ||
| fileName: path.resolve(flags.projectDir, 'cx-server', 'cx-server') | ||
| }, | ||
| { | ||
| sourcePath: new URL('server.cfg', githubPrefix), | ||
| targetFolder: path.resolve(flags.projectDir, 'cx-server'), | ||
| fileName: path.resolve(flags.projectDir, 'cx-server', 'server.cfg') | ||
| } | ||
| ]; |
There was a problem hiding this comment.
what happened to the .bat file? Shouldn't we keep Windows support?
There was a problem hiding this comment.
Also what happened to the concern about the number of relevant files potentially changing? No proper/sane way to implement it?
There was a problem hiding this comment.
So this is the result from a discussion with the pipeline team. They said that they consider only those two files essential and also consider the naming and folder structure as stable. So this seemed like the easiest way.
There are downsides, like the risk of breaking this command when the file names change. But I feel any other solution would likely be over-engineered or slow.
Henning also pointed out that we should keep the .bat while the pipeline team seemed to dismiss it. I will add it back in if the command is executed on a Windows machine.
Proposed Changes
This changes the behavior of
sap-cloud-sdk add-cx-serverto get the cx-server and server.cfg from the master branch of the respective github repo instead of copying files locally.This has the benefit that the files will always be the newest version, but it now requires internet connectivity to run (which can be assumed as the scripts need internet connectivity to run anyways).
Type of Changes
Breaking Changes
In general avoid breaking changes, but if you think it is necessary give your reasoning in the Further Comments section.