feat: Provide typed model parameters in LLM Module Config #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shibeshduw
changed the title
deekshas8
reviewed
Jan 3, 2025
shibeshduw
commented
Jan 7, 2025
| /** | ||
| * Model parameters should accept known typed parameters and arbitrary parameters. | ||
| */ | ||
| expectType<LlmModelParams>({ |
There was a problem hiding this comment.
Apparently this is not allowed. The TS compiler performs the excess property check before & Record<string, any> is read so it considers this type to be "too wide"? Would like some suggestions.
There was a problem hiding this comment.
I think the problem is not that it doesnt read Record<string, any> but rather that tsd expectType does strict type assertions -> https://github.com/tsdjs/tsd?tab=readme-ov-file#strict-type-assertions.
As suggested used expectAssignable instead
deekshas8
reviewed
Jan 9, 2025
deekshas8
reviewed
Jan 10, 2025
deekshas8
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
SAP/ai-sdk-js-backlog#83.