Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package-lock.json sync, white spaces and formatting cleanups #1013

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

jerome-benoit
Copy link
Collaborator

@jerome-benoit jerome-benoit commented Nov 26, 2022

Description

The mbt version upgrade automation does not properly regenerate package-lock.json.
The proper fix would be to fix the root cause.

Checklist

  • Code compiles correctly
  • Relevant tests were added (unit / contract / integration)
  • Relevant logs were added
  • Formatting and linting run locally successfully
  • All tests pass
  • UA review
  • Design is documented
  • Extended the README / documentation, if necessary
  • Open source is approved

Signed-off-by: Jérôme Benoit jerome.benoit@sap.com

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
Jérôme Benoit and others added 6 commits November 26, 2022 06:35
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
@jerome-benoit jerome-benoit changed the title Re-add sapjvm 8 docker images White spaces and formatting cleanups Feb 7, 2023
@jerome-benoit jerome-benoit changed the title White spaces and formatting cleanups package-lock.json sync, white spaces and formatting cleanups Feb 7, 2023
Copy link

cla-assistant bot commented Jul 16, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jerome-benoit
❌ Jérôme Benoit


Jérôme Benoit seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant