feat(python): Support Python builds using mbtci Docker images
#1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make builds of Python-based MTA apps feasible with the Docker images.
| @@ -270,7 +271,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ | |||
| && curl -fsSLO --compressed "https://github.com/CycloneDX/cyclonedx-cli/releases/download/v${CYCLONEDX_CLI_VERSION}/${CYCLONEDX_CLI_BINARY}-linux-${ARCH}" \ | |||
| && chmod a+rx ${CYCLONEDX_CLI_BINARY}-linux-${ARCH} \ | |||
| && mv ${CYCLONEDX_CLI_BINARY}-linux-${ARCH} /usr/local/bin/${CYCLONEDX_CLI_BINARY} \ | |||
| && apt-get remove --purge --autoremove -y ca-certificates curl gnupg dirmngr \ | |||
| && apt-get remove --purge --autoremove -y gnupg dirmngr \ | |||
There was a problem hiding this comment.
Security policy enforce that only toolchains must be part of the available binaries. Binaries allowing to ease HTTP, FTP, ... direct requests from the build env must be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change keeps
python3installed and addspython3-pipandpython3-dev, so that the resulting image can be used in Piper-based pipelines to build Python apps:pipmight be needed for vendoring the dependencies, during themtaBuild, so that the resulting MTA is self-contained when deployed in air-gapped CF.detectExecuteScanalso relies on thepiptool being available.I have not yet touched the tests, as I wanted to get the discussion rolling if this is a change you would likely merge.
I believe it would make sense to fully support Python in your Docker images as it is an enterprise-supported language when targeting SAP BTP, Cloud Foundry environment
In case you agree, I can adapt the tests as well.
Checklist