This repository has been archived by the owner on Sep 24, 2024. It is now read-only.
Fix tel format and card section clickable type #31
+71
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowTourist
force-pushed
the
fix-tel-format-and-card-section-clickable-type
branch
from
203a77f to
a4d7806
Compare
| @@ -133,6 +133,7 @@ extension CardSectionsView { | |||
|
|
|||
There was a problem hiding this comment.
@ShadowTourist #if DEBUG is needed as PreviewData is only available in DEBUG. I pushed fix ad1cdd3 so no worries :) this is just a FYI for further use
There was a problem hiding this comment.
👍 Thanks, I check the issues, this confused me before, I thought apple have fixed preview debug model issue.
But will fail release when preview use some Debug data only.
MarcoEidinger
pushed a commit
that referenced
this pull request
Aug 9, 2021
* fix: 🐛 trim all blank for tel url format * fix: 🐛 only show link email and phone number as clickable
ShadowTourist
deleted the
fix-tel-format-and-card-section-clickable-type
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tel format and limitation for button tap in
CardSectionView.