This repository has been archived by the owner on Sep 24, 2024. It is now read-only.
feat: 🎸 gif supported by SDWebImage #32
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| import Combine | ||
| import SDWebImage | ||
|
There was a problem hiding this comment. I don't think this is needed here. If so please remove |
||
| import SwiftUI | ||
|
|
||
| /// SwiftUI main view. Use this when you want a full screen out-of-the box view that contains: | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,16 @@ | ||
| import SwiftUI | ||
|
|
||
| struct AvatarView: View { | ||
| var imageUrl: String | ||
|
|
||
| var body: some View { | ||
| ImageViewWrapper(url: URL(string: imageUrl), | ||
| placeholder: { Image(systemName: "person.crop.circle") }, | ||
| failure: { _ in Image(systemName: "person.crop.circle") }, | ||
| content: { $0 }) | ||
| .scaledToFill() | ||
| .frame(width: 32, height: 32, alignment: .center) | ||
| .clipped() | ||
| } | ||
| } | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| import SwiftUI | ||
|
|
||
| struct CarouselImageView: View { | ||
| var media: MediaItem? | ||
|
|
@@ -13,18 +12,11 @@ struct CarouselImageView: View { | |
| var body: some View { | ||
| Group { | ||
| if let mediaItem = media, let sourceUrl = mediaItem.sourceUrl { | ||
| ImageViewWrapper(url: sourceUrl, | ||
| placeholder: { mediaItem.placeholder }, | ||
| failure: { Text($0.localizedDescription) }, | ||
| content: { $0 }) | ||
| .scaledToFill() | ||
| .frame(width: self.itemWidth, height: self.vSizeClass == .regular ? 180 : 80) | ||
| .clipped() | ||
| } else { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| import SwiftUI | ||
|
|
||
| /// Renders an image from a MediaItem data model | ||
| /// | ||
|
|
@@ -34,28 +33,25 @@ struct ImageUIView: View { | |
| self.fallback = fallback | ||
| } | ||
|
|
||
| var boundingBox: BoundingBox { | ||
| BoundingBox(minWidth: 44, | ||
| minHeight: 44, | ||
| maxWidth: self.hSizeClass == .regular ? 480 : self.geometry.size.width * 0.75, | ||
| maxHeight: self.vSizeClass == .regular ? 400 : 240) | ||
| } | ||
|
|
||
| // :nodoc: | ||
| var body: some View { | ||
| Group { | ||
| if let sourceUrl = media?.sourceUrl { | ||
| ImageViewWrapper(url: sourceUrl) { imgView in | ||
| let size = imgView.imageManager.imgSize | ||
| SizeConverter(size, boundingBox, content: { targetSize in | ||
| imgView.frame(width: targetSize.width, height: targetSize.height) | ||
| .preference(key: ImageSizeInfoPrefKey.self, value: targetSize) | ||
| }) | ||
| } | ||
| .scaledToFill() | ||
| } else { | ||
| fallback | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| import SwiftUI | ||
|
|
||
| /// Renders an image from a MediaItem data model | ||
| struct ImageView: View { | ||
|
|
@@ -10,16 +9,13 @@ struct ImageView: View { | |
| if imageUrl.absoluteString.range(of: "sap-icon") != nil { | ||
| IconImageView(iconUrl: imageUrl.absoluteString, iconSize: CGSize(width: 50, height: 50)) | ||
| } else { | ||
| ImageViewWrapper(url: imageUrl, | ||
| failure: { _ in | ||
| Image(systemName: "photo") | ||
| }, | ||
| content: { $0 }) | ||
| .scaledToFit() | ||
| .cornerRadius(8) | ||
| } | ||
| } | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| import SDWebImage | ||
| import SwiftUI | ||
|
|
||
| struct ImageViewRepresentable: UIViewRepresentable { | ||
| var url: URL? | ||
| var imageManager: ImageManager | ||
| let wrapper = UIImageViewWrapper() | ||
|
|
||
| func makeUIView(context: Self.Context) -> UIImageViewWrapper { | ||
| self.wrapper | ||
| } | ||
|
|
||
| func updateUIView(_ uiView: UIImageViewWrapper, context: UIViewRepresentableContext<ImageViewRepresentable>) { | ||
| uiView.imageView.contentMode = self.imageManager.contentMode | ||
| if case ImageManager.ImageState.error = self.imageManager.state, uiView.imageView.image == nil { | ||
| self.loadImage() | ||
| } | ||
| } | ||
|
|
||
| func loadImage() { | ||
| self.wrapper.imageView.sd_setImage(with: self.url, | ||
| placeholderImage: nil) { image, error, _, _ in | ||
| if let error = error { | ||
| imageManager.state = .error(error) | ||
| } else if let image = image { | ||
| imageManager.state = .completed(image: image) | ||
| } else { | ||
| imageManager.state = .error(NSError(domain: "cai.com", code: 1, userInfo: nil)) | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| class UIImageViewWrapper: UIView { | ||
| lazy var imageView: UIImageView = { | ||
| let imageView = UIImageView() | ||
| imageView.setContentCompressionResistancePriority(.defaultLow, for: .horizontal) | ||
| imageView.setContentCompressionResistancePriority(.defaultLow, for: .vertical) | ||
| imageView.setContentHuggingPriority(.defaultLow, for: .vertical) | ||
| imageView.setContentHuggingPriority(.defaultLow, for: .horizontal) | ||
| return imageView | ||
| }() | ||
|
|
||
| override init(frame: CGRect) { | ||
| super.init(frame: frame) | ||
| addSubview(self.imageView) | ||
| self.imageView.bindFrameToSuperviewBounds() | ||
| } | ||
|
|
||
| required init?(coder: NSCoder) { | ||
| super.init(coder: coder) | ||
| addSubview(self.imageView) | ||
| self.imageView.bindFrameToSuperviewBounds() | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.