feat: 🎸 [JIRA:HCPSDKFIORIUIKIT-2686] Button update #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billzhou0223
requested changes
Aug 1, 2024
| /// - loadingState: A state to show activity indicator or success icon, default is .unspecified. | ||
| /// - imagePosition: Place the image along the top, leading, bottom, or trailing edge of the button. | ||
| /// - imageTitleSpacing: spacing between image and title. | ||
| init(isSelectionPersistent: Bool = false, |
There was a problem hiding this comment.
Let's extend existing init to support image display.
public init(isSelectionPersistent: Bool = false,
action: ((UIControl.State) -> Void)? = nil,
@ViewBuilder label: @escaping (UIControl.State) -> any View，
@ViewBuilder image: @escaping (UIControl.State) -> any View = { _ in },
imagePosition: Position = .left,
spacing: CGFloat = 8)
You need to update other init accordingly as well. FioriButtonStyleConfiguration needs to be updated as well.
We need to provide default UI based on loading state. We can add a new style to achieve that.
FioriButton()
.fioriButtonStyle(FioriLoadingButtonStyle(state: .inProgress // or .success))
hengyi-zhang
force-pushed
the
feature/button-update
branch
from
45e27e0 to
060978a
Compare
hengyi-zhang
force-pushed
the
feature/button-update
branch
from
060978a to
6870097
Compare
dyongxu
added a commit
that referenced
this pull request
Aug 16, 2024
… other fixes (#776) * chore(release): 4.1.2 * fix: 🐛 [IOSSDKBUG-291] set line limit for MenuSelectionItem (#769) * fix: 🐛 [JIRA: IOSSDKBUG-306] toolbar layout issue (#771) * feat: 🎸 [JIRA:HCPSDKFIORIUIKIT-2686] Button update (#753) Co-authored-by: Bill Zhou <bill.zhou01@sap.com> * fix: 🐛 step progress indicator styles (#775) * Translation Delivery (#774) * [INTERNAL] Translation delivery: commit by LX Lab Change-Id: I111a249ae01afea6ba8029630027e1807e471499 * [INTERNAL] Translation delivery: commit by LX Lab Change-Id: I00c59b0e7a3bcd6346b6fddb8a51787bc132ace4 --------- Co-authored-by: dyongxu <61523257+dyongxu@users.noreply.github.com> --------- Co-authored-by: Marco Eidinger <marco.eidinger@sap.com> Co-authored-by: Bill Zhou <bill.zhou01@sap.com> Co-authored-by: Xiaoyu Liu <xiaoyuliu0722@gmail.com> Co-authored-by: hengyi-zhang <hengyizhangcn@gmail.com> Co-authored-by: SAP LX Lab Service Account <tmsatsls+github.com_service-tip-git@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.