Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 [JIRA:0] Update color based on UX review feedback #755

Merged
merged 2 commits into from
Aug 2, 2024
Merged

fix: 🐛 [JIRA:0] Update color based on UX review feedback #755

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4bb391
fix: 🐛 [JIRA:0] Update color based on UX review feedback
xiaoqinggracehe Aug 1, 2024
4236b21
Merge branch 'main' into main
xiaoqinggrace Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Sources/FioriSwiftUICore/_FioriStyles/InformationViewStyle.fiori.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ extension InformationViewFioriStyle {
struct ContentFioriStyle: InformationViewStyle {
func makeBody(_ configuration: InformationViewConfiguration) -> some View {
InformationView(configuration)
.foregroundColor(.preferredColor(.primaryLabel))
.foregroundColor(.preferredColor(.tertiaryLabel))
.padding(.top, 4)
.padding(.bottom, 11)
}
Expand All @@ -31,7 +31,7 @@ extension InformationViewFioriStyle {

func makeBody(_ configuration: IconConfiguration) -> some View {
Icon(configuration)
.foregroundStyle(Color.preferredColor(.primaryLabel))
.foregroundStyle(Color.preferredColor(.tertiaryLabel))
.font(.fiori(forTextStyle: .footnote))
}
}
Expand All @@ -41,7 +41,7 @@ extension InformationViewFioriStyle {

func makeBody(_ configuration: DescriptionConfiguration) -> some View {
Description(configuration)
.foregroundStyle(Color.preferredColor(.primaryLabel))
.foregroundStyle(Color.preferredColor(.tertiaryLabel))
.font(.fiori(forTextStyle: .footnote))
}
}
Expand Down Expand Up @@ -95,15 +95,15 @@ public struct InformationViewWarningStyle: InformationViewStyle {
.iconStyle(content: { IconConfiguration in
if IconConfiguration.icon.isEmpty {
Image(systemName: "exclamationmark.triangle")
.foregroundStyle(Color.preferredColor(.mango5))
.foregroundStyle(Color.preferredColor(.criticalLabel))
} else {
IconConfiguration.icon
.foregroundStyle(Color.preferredColor(.mango5))
.foregroundStyle(Color.preferredColor(.criticalLabel))
}
})
.descriptionStyle(content: { descriptionConfiguration in
descriptionConfiguration.description
.foregroundStyle(Color.preferredColor(.mango5))
.foregroundStyle(Color.preferredColor(.criticalLabel))
})
}
}
Expand Down
Loading