feat: 🎸 [JIRA:HCPSDKFIORIUIKIT-2716]Step Progress Indicator #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add stepProgressIndicatorNodeType for step node.
|
@xiaoyu0722 Can you review this enhancement as well ? |
billzhou0223
requested changes
Sep 4, 2024
Sources/FioriSwiftUICore/Views/StepProgressIndicator/StepItem.swift
Outdated
Show resolved
Hide resolved
xiaoyu0722
requested changes
Sep 5, 2024
Sources/FioriSwiftUICore/Views/StepProgressIndicator/StepItem.swift
Outdated
Show resolved
Hide resolved
billzhou0223
requested changes
Sep 6, 2024
Sources/FioriSwiftUICore/Views/StepProgressIndicator/StepItem.swift
Outdated
Show resolved
Hide resolved
Remove the mixture property of StepProgressIndicatorNodeType.
billzhou0223
requested changes
Sep 9, 2024
Sources/FioriSwiftUICore/Views/StepProgressIndicator/StepItem.swift
Outdated
Show resolved
Hide resolved
billzhou0223
requested changes
Sep 9, 2024
remove stepProgressIndicatorNodeType implementation
billzhou0223
requested changes
Sep 10, 2024
Sources/FioriSwiftUICore/Views/StepProgressIndicator/_DefaultSteps.swift
Outdated
Show resolved
Hide resolved
|
CI Error： The actions/download-artifact in CI.yml is version v1. |
billzhou0223
approved these changes
Sep 11, 2024
Version was taken care of by #799 |
xiaoyu0722
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Add stepProgressIndicatorNodeType for step node.Description
AddStepProgressIndicatorNodeTypefor stepProgressIndicator to set the nodetype style.+ mixture: Allow nodes to display numeric step and icon step in a mixture.+ icon: Only allow the display of icon step.+ text：Only allow the display of numeric step.add
TextorIconreplaceImage