Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 [JIRA:HCPSDKFIORIUIKIT-2717] Feedback Patterns #803

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

hengyi-zhang
Copy link
Contributor

No description provided.

@hengyi-zhang hengyi-zhang requested a review from a team as a code owner September 19, 2024 06:48
@hengyi-zhang hengyi-zhang requested review from billzhou0223 and removed request for a team September 19, 2024 06:48
@hengyi-zhang hengyi-zhang force-pushed the feat/HCPSDKFIORIUIKIT-2717 branch from e3efd0a to e94fcc7 Compare September 19, 2024 08:19
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sample code is for the application team's reference. Localization is not required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation is provided by another team.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need to add translation. There will be a translation process for product release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

@xiaoqinggrace
Copy link
Collaborator

UI components jump unexpectedly when deleting an entry on iPad. It can be fixed in a separate PR.

@hengyi-zhang hengyi-zhang force-pushed the feat/HCPSDKFIORIUIKIT-2717 branch from 1a078a1 to ff6c058 Compare September 23, 2024 01:28
@xiaoqinggrace xiaoqinggrace merged commit 01c1245 into SAP:main Sep 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants