Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🎸 [JIRA:HCPSDKFIORIUIKIT-2796]Loading Indicator #842

Merged
merged 10 commits into from
Nov 5, 2024
Merged

feat: 🎸 [JIRA:HCPSDKFIORIUIKIT-2796]Loading Indicator #842

merged 10 commits into from
Nov 5, 2024

Conversation

KevinZK
Copy link
Collaborator

@KevinZK KevinZK commented Oct 28, 2024 •
edited
Loading

Simulator Screenshot - iPhone 16 Pro Max - 2024-10-29 at 14 00 20

@KevinZK KevinZK requested a review from a team as a code owner October 28, 2024 05:44
@KevinZK KevinZK requested review from billzhou0223 and removed request for a team October 28, 2024 05:44
dyongxu
dyongxu requested changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@dyongxu dyongxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments embedded.

@dyongxu dyongxu requested a review from angiexyang October 29, 2024 17:00
@dyongxu
Copy link
Contributor

dyongxu commented Oct 29, 2024

@angiexyang This PR uses the native ProgressView as well. Can you also review this as well, to see if any consistency issue needs to be addressed ?

@angiexyang
Copy link
Collaborator

angiexyang commented Oct 29, 2024 •
edited
Loading

@angiexyang This PR uses the native ProgressView as well. Can you also review this as well, to see if any consistency issue needs to be addressed ?

ProgressIndicator doesn't use the native ProgressView. ProgressView only shows the indeterminate indicator on iOS, so no consistency issue

dyongxu
dyongxu requested changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@dyongxu dyongxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments inlined.
Also, re-order the indicator size test code, based on its size, by mini, small, large, extra large.

@KevinZK KevinZK requested a review from dyongxu October 31, 2024 01:11
@dyongxu dyongxu merged commit 23527b9 into SAP:main Nov 5, 2024
12 checks passed
@KevinZK KevinZK deleted the JIRA-2796_Loading-Indicator branch November 5, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyongxu dyongxu dyongxu approved these changes

@billzhou0223 billzhou0223 Awaiting requested review from billzhou0223 billzhou0223 is a code owner automatically assigned from SAP/cloud-sdk-ios-fiori-admin

@angiexyang angiexyang Awaiting requested review from angiexyang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinZK @dyongxu @angiexyang