Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 [JIRA:IOSSDKBUG-375] TextInput Fom View a11y fixes 1 #848

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix: 🐛 [JIRA:IOSSDKBUG-375] TextInput Fom View a11y fixes 1 #848

merged 1 commit into from
Oct 30, 2024

Conversation

janhuachu
Copy link
Contributor

  1. Fixes the mandatory indicator color problem.
  2. Fixes a11y problem with NoteFormView, KeyValueFormView, and, TitleFormView.
  3. For TextFieldFormView, the fix is not completed yet. There is still problem when alternative action button is present.

Note that the TextField and TextEditor is always read by VoiceOver no matter the order it is on the FormView. I think this is a SwiftUI behavior. We can change the order for UIKit but not SwiftUI. I believe this is a SwiftUI behavior.

@janhuachu janhuachu requested a review from a team as a code owner October 29, 2024 23:14
@janhuachu janhuachu requested review from billzhou0223 and removed request for a team October 29, 2024 23:14
@janhuachu janhuachu merged commit 7996515 into SAP:main Oct 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billzhou0223 billzhou0223 billzhou0223 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janhuachu @billzhou0223