Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🎸 [HCPSDKFIORIUIKIT-2683] [SwiftUI] Slider #940

Closed
wants to merge 2 commits into from
Closed

feat: 🎸 [HCPSDKFIORIUIKIT-2683] [SwiftUI] Slider #940

wants to merge 2 commits into from

Conversation

JunSong-SH
Copy link
Contributor

This PR addresses changes to support the Slider in the SDK.

HCPSDKFIORIUIKIT-2683 [SwiftUI] Slider
HCPSDKFIORIUIKIT-2684 [SwiftUI] Range Slider

The changes:

  • Built new base components: _LowerThumbComponent, _UpperThumbComponent, _ActiveTrackComponent, _InactiveTrackComponent, _LeadingAccessoryComponent and _TrailingAccessoryComponent
  • Built new composite components: _RangeSliderControlComponent, _FioriSliderComponent
  • Implement the logic to let FioriSlider component support standard slider and range slider both
  • Implement the Demo for FioriSlider.

See below screenshot:

StandardSliderRangeSlider

@JunSong-SH JunSong-SH requested a review from a team as a code owner December 17, 2024 07:38
@JunSong-SH JunSong-SH requested review from billzhou0223 and removed request for a team December 17, 2024 07:38
@JunSong-SH JunSong-SH force-pushed the main-slider branch 3 times, most recently from c0d01c3 to 10fe6dd Compare December 18, 2024 09:55
dyongxu
dyongxu requested changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@dyongxu dyongxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to see if possible to consolidate lots of the inits for different slides.

Sources/FioriSwiftUICore/DataTypes/FioriSlider+DataType.swift Outdated Show resolved Hide resolved
Sources/FioriSwiftUICore/DataTypes/FioriSlider+DataType.swift Outdated Show resolved Hide resolved
Sources/FioriSwiftUICore/DataTypes/FioriSlider+DataType.swift Outdated Show resolved Hide resolved
Sources/FioriSwiftUICore/DataTypes/FioriSlider+DataType.swift Outdated Show resolved Hide resolved
Sources/FioriSwiftUICore/DataTypes/FioriSlider+DataType.swift Outdated Show resolved Hide resolved
@JunSong-SH
Copy link
Contributor Author

Close this one and use new PR 945 for Slider

@JunSong-SH JunSong-SH closed this Dec 20, 2024
@JunSong-SH JunSong-SH mentioned this pull request Dec 20, 2024
Merged
@JunSong-SH JunSong-SH deleted the main-slider branch December 23, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyongxu dyongxu dyongxu requested changes

@billzhou0223 billzhou0223 Awaiting requested review from billzhou0223 billzhou0223 is a code owner automatically assigned from SAP/cloud-sdk-ios-fiori-admin

@xiaoyu0722 xiaoyu0722 Awaiting requested review from xiaoyu0722

@zzchao-1999 zzchao-1999 Awaiting requested review from zzchao-1999

@KevinZK KevinZK Awaiting requested review from KevinZK

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JunSong-SH @dyongxu @hengyi-zhang