Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Setup v4 #5243

Merged
merged 1 commit into from
Dec 5, 2024
Merged

chore: Setup v4 #5243

merged 1 commit into from
Dec 5, 2024

Conversation

deekshas8
Copy link
Contributor

@deekshas8 deekshas8 commented Dec 5, 2024 •
edited
Loading

Adjust workflows for main branch

  • I know which base branch I chose for this PR, as the default branch is v3-main now, which is not for v4 development.
  • If my change will be merged into the main branch (for v4), I've updated (V4-Upgrade-Guide.md)[./V4-Upgrade-Guide.md] in case my change has any implications for users updating to SDK v4

tomfrenken
tomfrenken approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@tomfrenken tomfrenken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deekshas8 deekshas8 merged commit b8d4ab7 into main Dec 5, 2024
17 checks passed
@deekshas8 deekshas8 deleted the setup-v4 branch December 5, 2024 14:57
ZhongpinWang pushed a commit that referenced this pull request Dec 20, 2024
@deekshas8 @ZhongpinWang
setup v4 (#5243)
f49cad8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomfrenken tomfrenken tomfrenken approved these changes

@jjtang1985 jjtang1985 Awaiting requested review from jjtang1985

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deekshas8 @tomfrenken