-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch v3 js docs #1138
Branch v3 js docs #1138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. I think the behavior for v2 should not be changed as long as its the default.
@FrankEssenberger I think this is a unrelated change we discussed in a recent refinement. Not sure in which commit this was changed, but I'd be surprised if my PR caused that change. Also I think this is now the expected behaviour, so I don't know what to change. notify @tomfrenken @marikaner @jjtang1985 anyone diagrees? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Branched v3 docs for js sdk
Default (for now) is v2. V3 docs have an 'unreleased' marker.