Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V5 Update Guide #1601

Merged
merged 31 commits into from
Dec 5, 2023
Merged

V5 Update Guide #1601

merged 31 commits into from
Dec 5, 2023

Conversation

cschubertcs
Copy link
Member

What Has Changed?

This PR introduces an update guide on how to go from v4 to v5.
It takes over some of the update notes we took and creates a step-by-step guide out of it.

If we migrate everything over into the step-by-step guide we can also remove the original update notes.

Johannes-Schneider
Johannes-Schneider reviewed Nov 17, 2023
View reviewed changes
docs-java_versioned_docs/version-v5/guides/5.0-upgrade-steps.mdx Outdated Show resolved Hide resolved
docs-java_versioned_docs/version-v5/guides/5.0-upgrade-steps.mdx Outdated Show resolved Hide resolved
docs-java_versioned_docs/version-v5/guides/5.0-upgrade-steps.mdx Outdated Show resolved Hide resolved
docs-java_versioned_docs/version-v5/guides/5.0-upgrade-steps.mdx Outdated Show resolved Hide resolved
docs-java_versioned_docs/version-v5/guides/5.0-upgrade-steps.mdx Outdated Show resolved Hide resolved
docs-java_versioned_docs/version-v5/guides/5.0-upgrade-steps.mdx Outdated Show resolved Hide resolved
docs-java_versioned_docs/version-v5/guides/5.0-upgrade-steps.mdx Show resolved Hide resolved
docs-java_versioned_docs/version-v5/guides/5.0-upgrade-steps.mdx Show resolved Hide resolved
docs-java_versioned_docs/version-v5/guides/5.0-upgrade-steps.mdx Outdated Show resolved Hide resolved
docs-java_versioned_docs/version-v5/guides/5.0-upgrade-steps.mdx Outdated Show resolved Hide resolved
@CharlesDuboisSAP
Copy link
Contributor

CharlesDuboisSAP commented Nov 21, 2023 •
edited
Loading

Will the 2 separate migration pages be merged into 1 when this PR is ready to be merged?

@cschubertcs
Copy link
Member Author

Will the 2 separate migration pages be merged into 1 when this PR is ready to be merged?

Yes, that is the plan. I wanted to keep the "other" one for reference and also prevent merge conflicts.

@CharlesDuboisSAP
Copy link
Contributor

CharlesDuboisSAP commented Nov 22, 2023 •
edited
Loading

Also customers need to revert every step there and also there.

MatKuhr
MatKuhr reviewed Nov 27, 2023
View reviewed changes
Copy link
Member

@MatKuhr MatKuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like there is still some stuff missing here. E.g. the renaming from ScpCfDestinationLoader -> DestinationService. Also there are a lot more modules that may require changing e.g. the removed tenant-scp-cf or the new connectivity-auth or everything on the updated DefaultHttpDestination (where something seems to have been added to the "other" guide)

docs-java_versioned_docs/version-v5/guides/5.0-upgrade-steps.mdx Outdated Show resolved Hide resolved
docs-java_versioned_docs/version-v5/guides/5.0-upgrade-steps.mdx Outdated Show resolved Hide resolved
@CharlesDuboisSAP CharlesDuboisSAP mentioned this pull request Nov 28, 2023
Merged
10 tasks
@cschubertcs cschubertcs marked this pull request as ready for review December 1, 2023 13:30
@cschubertcs
Copy link
Member Author

Still needs some more details in the table of removed APIs.
I will have a look on the weekend.

@cschubertcs
Copy link
Member Author

But it can anyway be reviewed and merged right now.

@cschubertcs cschubertcs enabled auto-merge (squash) December 4, 2023 09:02
KavithaSiva
KavithaSiva reviewed Dec 5, 2023
View reviewed changes
docs-java_versioned_docs/version-v5/guides/5.0-upgrade-steps.mdx
This JEP provides a good overview of the changes: [JEP 320: Remove the Java EE and CORBA Modules](https://openjdk.java.net/jeps/320).

If you are consuming SOAP APIs and are relying on the `axis2-wsdl2code-maven-plugin` to generate classes, please also additionally include `javax.activation:activation` artifact to your dependencies to avoid compilation errors.

Copy link
Contributor

@KavithaSiva KavithaSiva Dec 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order of update note, first Java followed by SDK+Spring together seems to have been dropped somehow. I guess you decided to have this explained in the section below.

But, I think it would still be beneficial to have this as a tip.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair, it's implicitly mentioned by the order of the sections, but a concrete hint will be helpful.

@cschubertcs cschubertcs merged commit 8291d44 into main Dec 5, 2023
7 checks passed
@cschubertcs cschubertcs deleted the v5-update-guide branch December 5, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesDuboisSAP CharlesDuboisSAP CharlesDuboisSAP left review comments

@KavithaSiva KavithaSiva KavithaSiva left review comments

@Johannes-Schneider Johannes-Schneider Johannes-Schneider left review comments

@MatKuhr MatKuhr MatKuhr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cschubertcs @CharlesDuboisSAP @Johannes-Schneider @KavithaSiva @MatKuhr