Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add serialization docs #1607

Merged
merged 3 commits into from
Nov 28, 2023
Merged

chore: Add serialization docs #1607

merged 3 commits into from
Nov 28, 2023

Conversation

tomfrenken
Copy link
Member

What Has Changed?

With this PR, the changes in SAP/cloud-sdk-js#4295 are reflected.

To configure the serialization of the URLs within a batch request, you can set the subrequest path type with the `withSubRequestPathType()` method.
You can either set it to `relativeToService` (default), which will yield URLs relative to the entity, or `absolute`, which will produce absolute URLs.
To configure the serialization of the URLs within a batch request, you can set the subrequest path type using the `withSubRequestPathType()` method.
You can choose from the following options: `relativeToService` (default), which yields URLs relative to the service; `relativeToEntity`, which yields URLs relative to the entity; `absolute`, which produces absolute URLs; or `noPath`, which only returns the entity with no preceding path.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pp] I am not a fan of the semicolon list, how about a list?
[nth] Maybe consider additionally mentioning that noPath is the same as relativetoEntity without leading slash

@tomfrenken tomfrenken merged commit aaf88c8 into main Nov 28, 2023
7 checks passed
@tomfrenken tomfrenken deleted the update-serialization branch November 28, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants