Removed mentions of Java 8 #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatKuhr
reviewed
Nov 29, 2023
MatKuhr
reviewed
Nov 29, 2023
| <TabItem value="spring5"> | ||
|
|
||
| For a **Spring 5** based project please ensure that the application is annotated to scan for components of the SAP Cloud SDK: | ||
| Please ensure that the application is annotated to scan for components of the SAP Cloud SDK: | ||
|
|
||
| ```java | ||
| @ComponentScan({"com.sap.cloud.sdk", <your.own.package>}) |
There was a problem hiding this comment.
this needs the Jakarta annotation instead
There was a problem hiding this comment.
Isn't this the workaround:
@ServletComponentScan({"com.sap.cloud.sdk.cloudplatform.servletjakarta", <your.own.package>})Meaning that applications can go back to:
@ServletComponentScan({"com.sap.cloud.sdk", <your.own.package>})Because it will find the only servlet which is jakarta-servlet
MatKuhr
reviewed
Nov 29, 2023
MatKuhr
reviewed
Nov 29, 2023
docs-java_versioned_docs/version-v5/guides/spring-boot-war-deployment.mdx
Show resolved
Hide resolved
MatKuhr
reviewed
Nov 29, 2023
MatKuhr
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Has Changed?
I updated all mentions of Java 8 to Java 17 in the v5 docs
This is part of Update Major Dependency Versions#351
Note to reviewer: Double check the changes in the linux guide