-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add no-icon modifier for alert to match UI Kit v1.4.3 #1493
Conversation
no icon
modifier for alert
no icon
modifier for alert
Deploy preview for fundamental ready! Built with commit 0e49949 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we double check the size of the icons? They look big. The close icon should be 16px and 12px from the edge. The icons on the left should be 16px and also 12px from the edge.
@saad-mo can you cherry pick this in |
@LeoT7508 updated the icon and close button size. it was indeed bigger. https://deploy-preview-1493--fundamental.netlify.com/components/alert.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the height of these are off, looks like it might be 38px, it should be 40px tall. The close icon looks right.
height on a single line alert updated to 40px - https://deploy-preview-1493--fundamental.netlify.com/components/alert.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Positioning is correct.
* add `no-icon` modifier to alerts
Closes #1492
adds
no-icon
modifier to renderinformation
,success
,warning
anderror
without an iconTest
Changelog
New
no-icon
modifierChanged
nothing
Removed
nothing