Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add new call to action #1571

Merged
merged 8 commits into from
Nov 18, 2020
Merged

docs: add new call to action #1571

merged 8 commits into from
Nov 18, 2020

Conversation

stefanoScalzo
Copy link
Contributor

Closes #1570

Adds a call to action for the landing page

@netlify
Copy link

netlify bot commented Oct 28, 2020 •
edited
Loading

Deploy preview for fundamental ready!

Built with commit 2b68e4c

https://deploy-preview-1571--fundamental.netlify.app

jessmetivier
jessmetivier suggested changes Oct 30, 2020
View reviewed changes
Copy link

@jessmetivier jessmetivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey stefano, please check out all the content and switch the text to the updated ones.

Also the grey container's bottom has too much padding. The padding looks off for the buttons too, especially on the left and right sides.

@jessmetivier

This comment has been minimized.

Sign in to view
@stefanoScalzo
Copy link
Contributor Author

stefanoScalzo commented Oct 30, 2020 •
edited
Loading

Hey stefano, please check out all the content and switch the text to the updated ones.

Also the grey container's bottom has too much padding. The padding looks off for the buttons too, especially on the left and right sides.

Padding is 8px in between buttons and the sections all share a 140px padding. Content is changed

@jessmetivier

This comment has been minimized.

Sign in to view
@jessmetivier

This comment has been minimized.

Sign in to view
jessmetivier
jessmetivier suggested changes Oct 30, 2020
View reviewed changes
Copy link

@jessmetivier jessmetivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments

@jessmetivier
Copy link

jessmetivier commented Oct 30, 2020 •
edited
Loading

Last thing (for now), great job with the button interaction states 👍🏼

@jessmetivier

This comment has been minimized.

Sign in to view
jessmetivier
jessmetivier suggested changes Nov 2, 2020
View reviewed changes
Copy link

@jessmetivier jessmetivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments

@stefanoScalzo
Copy link
Contributor Author

Please see comments

fixed

jessmetivier
jessmetivier suggested changes Nov 4, 2020
View reviewed changes
Copy link

@jessmetivier jessmetivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey stefano, thanks for making the changes.

It still seems like there's a lot of padding between the CTA section and the UI kit details:
Screen Shot 2020-11-04 at 9 42 37 AM

There should only be 44 px.

@stefanoScalzo
Copy link
Contributor Author

Hey stefano, thanks for making the changes.

It still seems like there's a lot of padding between the CTA section and the UI kit details:
Screen Shot 2020-11-04 at 9 42 37 AM

There should only be 44 px.

fixed

@jessmetivier
Copy link

jessmetivier commented Nov 4, 2020 •
edited
Loading

Looks great, only thing that looks off to me is the padding between the regular text and the buttons. Is it 20px?

Also the text in the Download UI kit buttons is smaller than the other button...

jessmetivier
jessmetivier suggested changes Nov 4, 2020
View reviewed changes
Copy link

@jessmetivier jessmetivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments

@stefanoScalzo
Copy link
Contributor Author

fixed

jessmetivier
jessmetivier suggested changes Nov 10, 2020
View reviewed changes
Copy link

@jessmetivier jessmetivier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Button height looks too high:
Screen Shot 2020-11-10 at 9 45 25 AM

This is what they're supposed to look like:
Screen Shot 2020-11-10 at 9 44 53 AM

Are the buttons 44px high, and have 35px padding from left-right, and 12px from the top to bottom from the text?

@stefanoScalzo
Copy link
Contributor Author

Button height looks too high:
Screen Shot 2020-11-10 at 9 45 25 AM

This is what they're supposed to look like:
Screen Shot 2020-11-10 at 9 44 53 AM

Are the buttons 44px high, and have 35px padding from left-right, and 12px from the top to bottom from the text?

fixed

jessmetivier
jessmetivier approved these changes Nov 10, 2020
View reviewed changes
Copy link

@jessmetivier jessmetivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@stefanoScalzo stefanoScalzo merged commit c81648e into master Nov 18, 2020
@stefanoScalzo stefanoScalzo deleted the docs-call-to-action branch November 18, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessmetivier jessmetivier jessmetivier approved these changes

@droshev droshev droshev approved these changes

@InnaAtanasova InnaAtanasova Awaiting requested review from InnaAtanasova

Assignees
No one assigned
Labels
landing page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Add call to action for design component in landing page
3 participants
@stefanoScalzo @jessmetivier @droshev