Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch go.mod version to Go 1.21.0 #135

Closed
mx-psi opened this issue Apr 23, 2024 · 2 comments · Fixed by #136
Closed

Switch go.mod version to Go 1.21.0 #135

mx-psi opened this issue Apr 23, 2024 · 2 comments · Fixed by #136
Labels

Comments

@mx-psi
Copy link

mx-psi commented Apr 23, 2024

On a38bb01 the go directive was changed to go 1.21.9. Quoting the Go mod file reference:

A go directive indicates that a module was written assuming the semantics of a given version of Go.

I believe this can be safely changed to go 1.21.0, since the semantics are similar between Go 1.21.0 and Go 1.21.9. The current version makes it impossible for modules that depend on go-hdb to be built with Go versions between 1.21.0 and 1.21.9.

@mx-psi mx-psi changed the title Switch go.mod version to Go 1.21 Switch go.mod version to Go 1.21.0 Apr 23, 2024
@stfnmllr
Copy link
Contributor

@mx-psi yes, thanks - go directive is change to 1.21.0 with go-hdb v1.8.20

@mx-psi
Copy link
Author

mx-psi commented Apr 23, 2024

Thank you for the extremely quick turn around! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants