Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider going back to go 1.21 in go.mod directive #138

Closed
mx-psi opened this issue Jun 10, 2024 · 2 comments
Closed

Consider going back to go 1.21 in go.mod directive #138

mx-psi opened this issue Jun 10, 2024 · 2 comments
Labels

Comments

@mx-psi
Copy link

mx-psi commented Jun 10, 2024

Hi! A few weeks ago, on v1.8.19, you switched to having bugfix version in your Go mod and I suggested setting that to go 1.21.0 in #135.

Since then, I have discussed elsewhere this cilium/ebpf/pull/1441 and found this change golang/go@27ed85d that was released in Go 1.21.11 and Go 1.22.4 that I think probably fixed the issue that motivated this change (go 1.21 -> go 1.21.9) in the first place (this one golang/go/issues/62278).

Would you be willing to change the directive back to go 1.21? If not, what's the motivation? For context, I maintain a project that depends on go-hdb and want both to

  1. be able to depend on go 1.21 instead of go 1.21.0 (this has some smaller differences and in general seems more appropriate for a library)
  2. understand the motivation to change this on go-hdb to see if I should instead change it on my end.

Thanks!

@stfnmllr
Copy link
Contributor

Hello,
yes, as long as no 'tool' is going to complain, I am fine with 'go1.21' and did the change with
https://github.com/SAP/go-hdb/releases/tag/v1.9.8.
This is earliest going to change again (to 'go1.22') after the next go release ('go1.23') will be available.

@mx-psi
Copy link
Author

mx-psi commented Jun 10, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants