Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Scopes: Add test for attribute selectors with quotes #260

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

RandomByte
Copy link
Member

Reusing the existing tests for HTML queries by adding quotes to some of
the attribute selectors and compressing the CSS before parsing it.

This targets a regression in the @adobe/css fork of css as reported
here: adobe/css-tools#77

@RandomByte
Copy link
Member Author

RandomByte commented Dec 9, 2022

Diff of the relevant build output using reworkcss/css (-) and adobe/css-tools (+):

html[dir=rtl][data-sap-ui-browser^=ie] .sapUiGrid th>.sapUiFormTitle,
html[dir=rtl][data-sap-ui-browser^=ie] .sapUiGrid td>.sapUiFormTitle,
html[dir=rtl][data-sap-ui-browser^=ed] .sapUiGrid th>.sapUiFormTitle,
html[dir=rtl][data-sap-ui-browser^=ed] .sapUiGrid td>.sapUiFormTitle {
	color:#000000
}

html[dir=rtl][data-sap-ui-browser^='ie'].sapUiGrid th>.sapUiFormTitle,
html[dir=rtl][data-sap-ui-browser^='ie'].sapUiGrid td>.sapUiFormTitle,
html[dir=rtl][data-sap-ui-browser^='ed'].sapUiGrid th>.sapUiFormTitle,
html[dir=rtl][data-sap-ui-browser^='ed'].sapUiGrid td>.sapUiFormTitle {
	color:#000000
}

html[dir=rtl][data-sap-ui-browser^=ie].sap-desktop-sapUiClass .testClass {
	color:#000000
}

html[dir=rtl][data-sap-ui-browser^=ie] .fooContrast .sapUiGrid th>.sapUiFormTitle,
html[dir=rtl][data-sap-ui-browser^=ie] .fooContrast.sapUiGrid th>.sapUiFormTitle,
html[dir=rtl][data-sap-ui-browser^=ie] .fooContrast .sapUiGrid td>.sapUiFormTitle,
html[dir=rtl][data-sap-ui-browser^=ie] .fooContrast.sapUiGrid td>.sapUiFormTitle,
html[dir=rtl][data-sap-ui-browser^=ed] .fooContrast .sapUiGrid th>.sapUiFormTitle,
html[dir=rtl][data-sap-ui-browser^=ed] .fooContrast.sapUiGrid th>.sapUiFormTitle,
html[dir=rtl][data-sap-ui-browser^=ed] .fooContrast .sapUiGrid td>.sapUiFormTitle,
html[dir=rtl][data-sap-ui-browser^=ed] .fooContrast.sapUiGrid td>.sapUiFormTitle {
	color:#ffffff;
}

-html[dir=rtl][data-sap-ui-browser^='ie'].sapUiGrid .fooContrast th>.sapUiFormTitle,
-html[dir=rtl][data-sap-ui-browser^='ie'].sapUiGrid .fooContrast td>.sapUiFormTitle,
-html[dir=rtl][data-sap-ui-browser^='ed'].sapUiGrid .fooContrast th>.sapUiFormTitle,
-html[dir=rtl][data-sap-ui-browser^='ed'].sapUiGrid .fooContrast td>.sapUiFormTitle {
+html[dir=rtl][data-sap-ui-browser^='ie'].sapUiGrid .fooContrast th>.sapUiFormTitle, {
 	color:#ffffff;
 }

html[dir=rtl][data-sap-ui-browser^=ie].sap-desktop-sapUiClass .fooContrast .testClass,
html[dir=rtl][data-sap-ui-browser^=ie].sap-desktop-sapUiClass .fooContrast.testClass {
	color:#ffffff;
}

(scroll to see diff; manual formatting of compressed CSS by me)

Reusing the existing tests for HTML queries by adding quotes to some of
the attribute selectors and compressing the CSS before parsing it.

This targets a regression in the @adobe/css fork of css as reported
here: adobe/css-tools#77
@RandomByte RandomByte merged commit e5ea9cf into master Dec 16, 2022
@RandomByte RandomByte deleted the add-attr-selector-tests branch December 16, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants