-
Notifications
You must be signed in to change notification settings - Fork 18
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
build: remove unnecessary repositories from Gradle files and bump Gradle
Removing mavenLocal and gradlePluginPortal from repositories declaration and removing pluginManagement / repositories block in settings.gradle entirely. Removing mavenLocal reduces the risk of local-only failure, due to some leftover / old / locally built build depenencies for Vert.x or any other of the used dependencies. Often times it would be next to impossible to locate issues with a contributors failing local build, if mavenLocal stays in the configuration. If local references are required for testing, contributors should be inclined adding mavenLocal to the repositories block themselfs. Having gradlePluginPortal in the repositories block makes no sense, as plugins are anyways loaded via the pluginManagement directive. After removing mavenLocal from the pluginManagement / repositories section, the leftover gradlePluginPortal section there is considered the default setting in Gradle and thus the whole block could be removed.
- Loading branch information
Showing
6 changed files
with
23 additions
and
46 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7.1-bin.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-6.8.3-bin.zip | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1 @@ | ||
pluginManagement { | ||
repositories { | ||
mavenLocal() | ||
gradlePluginPortal() | ||
} | ||
} | ||
|
||
rootProject.name = 'neonbee-core' |