Skip to content

Commit

Permalink
Merge branch 'develop' into feature/CXSPA-9334
Browse files Browse the repository at this point in the history
  • Loading branch information
andreighervan7 authored Feb 11, 2025
2 parents 732a1d0 + 1d38089 commit a6d4bf2
Show file tree
Hide file tree
Showing 323 changed files with 10,885 additions and 334 deletions.
3 changes: 1 addition & 2 deletions .env-cmdrc
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@
"CX_BASE_URL": "https://api.cg79x9wuu9-eccommerc1-p1-public.model-t.myhybris.cloud"
},
"cds": {
"CX_CDS": "true",
"CX_SCI": "false"
"CX_CDS": "true"
},
"lighthouse": {
"CX_BASE_URL": "https://api.spartacus.rocks"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,22 @@

New Angular 19 apps are configured a bit differently than the Angular 17 apps migrated to v19. This document is a migration guide for modernizing the migrated apps to look as much as possible like the new Angular 19 apps.

# Automatic migration

The Spartacus team provides special schematics that automatically modernize the app to look as much as possible like the new Angular 19 apps.

Please run the following command from your project root directory:

```bash
ng g @spartacus/schematics:modernize-app-migrated-from-2211_32-to-2211_35
```

In case of any issues during the automatic migration, you can always fall back to the manual migration steps below.

# Manual migration

Here are the migration steps in detail:

### `angular.json`

1. In the section `architect > build > options > assets`, please replace 2 string values in the array: `"src/favicon.ico"` and `"src/assets"` with a single object `{ "glob": "**/*", "input": "public" }`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,40 @@ The benefits of using the new Angular configuration format are:
The side-effect consequences of using the new configuration format are:
- For SSR apps: the server-side rendering and prerendering scripts will be executed differently (it will be explained in the last section of this page "[New commands for SSR projects](#new-commands-for-ssr-projects)")


# Automatic migration

The Spartacus team provides special schematics that automatically modernize the app to look as much as possible like the new Angular 17 apps.

Note: the tool was released only in `@spartacus/schematics` v2211.35.0, but you need to run it before fully upgrading your app to this version.
To do this, you'll need to install `@spartacus/schematics@2211.35.0` in a temporary directory and execute the migration schematic from there.

Please run those commands from your project root directory:

```bash
# 1. Create a temporary sibling directory for the isolated Schematics v2211.35 installation
node -e "require('fs').mkdirSync('../temp-schematics-35')"

# 2. Install schematics in the temporary directory
npm install @spartacus/schematics@2211.35.0 --prefix ../temp-schematics-35

# 3. Execute in your project the schematics from the temporary directory
ng g ../temp-schematics-35/node_modules/@spartacus/schematics:modernize-app-migrated-from-6_8-to-2211_19

# 4. Clean up the temporary directory
node -e "require('fs').rmSync('../temp-schematics-35', { recursive: true, force: true })"
```

In case of any issues during the automatic migration, you can always fall back to the manual migration steps below.

> ⚠️ Warning:
>
> Reminder for SSR apps: from now on the server-side rendering and prerendering scripts will be executed differently (see the last section of this page "[New commands for SSR projects](#new-commands-for-ssr-projects)")
In case of any issues during the automatic migration, you can always fall back to the manual migration steps below.

# Manual migration

Here are the migration steps in detail:

## Migration to the new Angular `application` builder
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"recurrencePeriodType_MONTHLY": "Měsíc",
"dayOfMonth": "Dne",
"startOn": "Začít dne",
"repeatOnDays": "Opakovat v následujících dnech"
"repeatOnDays": "Opakovat v následujících dnech",
"duration": "Doba trvání"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"recurrencePeriodType_MONTHLY": "Monat",
"dayOfMonth": "Am Tag",
"startOn": "Start am",
"repeatOnDays": "An den folgenden Tagen wiederholen"
"repeatOnDays": "An den folgenden Tagen wiederholen",
"duration": "Dauer"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"recurrencePeriodType_MONTHLY": "Mes",
"dayOfMonth": "El día",
"startOn": "Fecha de inicio",
"repeatOnDays": "Repetir en los siguientes días"
"repeatOnDays": "Repetir en los siguientes días",
"duration": "Duración"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"recurrencePeriodType_MONTHLY": "Mes",
"dayOfMonth": "El día",
"startOn": "Fecha de inicio",
"repeatOnDays": "Repetir en los siguientes días"
"repeatOnDays": "Repetir en los siguientes días",
"duration": "Duración"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"recurrencePeriodType_MONTHLY": "mois",
"dayOfMonth": "À la date",
"startOn": "Début le",
"repeatOnDays": "Répéter les jours suivants"
"repeatOnDays": "Répéter les jours suivants",
"duration": "Durée"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"recurrencePeriodType_MONTHLY": "माह",
"dayOfMonth": "दिन पर",
"startOn": "प्रारंभ दिनांक",
"repeatOnDays": "निम्न दिनों पर फिर से करें"
"repeatOnDays": "निम्न दिनों पर फिर से करें",
"duration": "अवधि"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"recurrencePeriodType_MONTHLY": "Hónap",
"dayOfMonth": "Adott napon",
"startOn": "Kezdés dátuma",
"repeatOnDays": "Ismétlés a következő napokon:"
"repeatOnDays": "Ismétlés a következő napokon:",
"duration": "Időtartam"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"recurrencePeriodType_MONTHLY": "Bulan",
"dayOfMonth": "Pada hari",
"startOn": "Dimulai pada",
"repeatOnDays": "Ulangi di hari berikutnya"
"repeatOnDays": "Ulangi di hari berikutnya",
"duration": "Durasi"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"recurrencePeriodType_MONTHLY": "Mese",
"dayOfMonth": "Il giorno",
"startOn": "Inizia il",
"repeatOnDays": "Ripeti nei seguenti giorni"
"repeatOnDays": "Ripeti nei seguenti giorni",
"duration": "Durata"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"recurrencePeriodType_MONTHLY": "",
"dayOfMonth": "特定の日にち",
"startOn": "開始日",
"repeatOnDays": "以下の曜日に繰り返し"
"repeatOnDays": "以下の曜日に繰り返し",
"duration": "期間"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"recurrencePeriodType_MONTHLY": "개월",
"dayOfMonth": "당일",
"startOn": "시작 날짜",
"repeatOnDays": "다음 날짜에 반복"
"repeatOnDays": "다음 날짜에 반복",
"duration": "기간"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"recurrencePeriodType_MONTHLY": "Miesiąc",
"dayOfMonth": "Dnia",
"startOn": "Data rozpoczęcia",
"repeatOnDays": "Powtarzaj w następne dni"
"repeatOnDays": "Powtarzaj w następne dni",
"duration": "Czas trwania"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"recurrencePeriodType_MONTHLY": "Mês",
"dayOfMonth": "No dia",
"startOn": "Iniciar em",
"repeatOnDays": "Repetir nos dias seguintes"
"repeatOnDays": "Repetir nos dias seguintes",
"duration": "Duração"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"recurrencePeriodType_MONTHLY": "месяц",
"dayOfMonth": "день месяца",
"startOn": "Начало",
"repeatOnDays": "Повторять по следующим дням"
"repeatOnDays": "Повторять по следующим дням",
"duration": "Продолжительность"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"recurrencePeriodType_MONTHLY": "",
"dayOfMonth": "日期",
"startOn": "开始日期",
"repeatOnDays": "以下日期重复"
"repeatOnDays": "以下日期重复",
"duration": "持续时间"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"recurrencePeriodType_MONTHLY": "",
"dayOfMonth": "於日期",
"startOn": "開始日期",
"repeatOnDays": "於下列日期重複"
"repeatOnDays": "於下列日期重複",
"duration": "持續期"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
"label": "Title (optional)",
"placeholder": "Title"
},
"titleCodeOnOTPForm": {
"label": "Title",
"placeholder": "Select Title"
},
"firstName": {
"label": "First name",
"placeholder": "First name"
Expand All @@ -25,38 +29,71 @@
"label": "City/Town (optional)",
"placeholder": "Please select City/Town"
},
"cityOnOTPForm": {
"label": "City/Town",
"placeholder": "Please select City/Town"
},
"country": {
"label": "Country (optional)",
"placeholder": "Select Country"
},
"countryOnOTPForm": {
"label": "Country",
"placeholder": "Select Country"
},
"state": {
"label": "State/Province (optional)",
"placeholder": "Select State/Province"
},
"stateOnOTPForm": {
"label": "State/Province",
"placeholder": "Select State/Province"
},
"postalCode": {
"label": "Zip/Postal code (optional)",
"placeholder": "Zip/Postal code"
},
"postalCodeOnOTPForm": {
"label": "Zip/Postal code",
"placeholder": "Zip/Postal code"
},
"addressLine": {
"label": "Address (optional)",
"placeholder": "Address"
},
"addressLineOnOTPForm": {
"label": "Address",
"placeholder": "Address"
},
"secondAddressLine": {
"label": "Address line 2 (optional)",
"placeholder": "Address line 2"
},
"secondAddressLineOnOTPForm": {
"label": "Address line 2",
"placeholder": "Address line 2"
},
"phoneNumber": {
"label": "Phone number (optional)",
"placeholder": "Phone number"
},
"phoneNumberOnOTPForm": {
"label": "Phone number",
"placeholder": "Phone number"
},
"message": {
"label": "Message (optional)",
"placeholder": "An example data for the message field: \"Department: Ground support; Position: Chief safe guard; Report to: Steve Jackson; Comments: Please create new account for me\"."
},
"messageOnOTPForm": {
"label": "Message",
"placeholder": "An example data for the message field: \"Department: Ground support; Position: Chief safe guard; Report to: Steve Jackson; Comments: Please create new account for me\"."
}
},
"messageToApproverTemplate": "Company name: {{companyName}},\n Phone number: {{phoneNumber}},\n Address: {{addressLine}} {{secondAddressLine}} {{city}} {{state}} {{postalCode}} {{country}},\n Message: {{message}}",
"successFormSubmitMessage": "Thank you for registering! A representative will contact you shortly and confirm your access information.",
"formSubmitButtonLabel": "Register",
"continueWithOTP": "Continue",
"goToLoginButtonLabel": "Already registered? Go to Sign in",
"httpHandlers": {
"conflict": "User with this e-mail address already exists."
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,5 @@

export * from './user-registration-components.module';
export * from './form/index';
export * from './registration-otp-form/index';
export * from './verification-token-form/index';
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
/*
* SPDX-FileCopyrightText: 2025 SAP Spartacus team <spartacus-team@sap.com>
*
* SPDX-License-Identifier: Apache-2.0
*/

export * from './user-registration-otp-form.component';
export * from './user-registration-otp-form.module';
Loading

0 comments on commit a6d4bf2

Please sign in to comment.