Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update e2e cart helpers to use JSON for 2105 #12366

Closed
LTiger14 opened this issue May 10, 2021 · 0 comments · Fixed by #12368
Closed

Update e2e cart helpers to use JSON for 2105 #12366

LTiger14 opened this issue May 10, 2021 · 0 comments · Fixed by #12368
Assignees
@LTiger14
Labels
bug Something isn't working
Milestone
before-5.0

Comments

@LTiger14
Copy link

In #12092 the adapters were updated to use JSON for certain operations.

Some e2e helpers also need to be updated so the E2Es pass on 2105.

The e2e tests should still pass on 2005 (travis).
@LTiger14 LTiger14 added the bug Something isn't working label May 10, 2021
@LTiger14 LTiger14 self-assigned this May 10, 2021
LTiger14 pushed a commit that referenced this issue May 10, 2021
GH-12366: update helper functions
f4a5e78
@LTiger14 LTiger14 mentioned this issue May 10, 2021
Merged
LTiger14 pushed a commit that referenced this issue May 10, 2021
Merge branch 'develop' into feature/GH-12366
fdc9ac8
LTiger14 pushed a commit that referenced this issue May 10, 2021
Merge branch 'develop' into feature/GH-12366
74c9a44
LTiger14 pushed a commit that referenced this issue May 10, 2021
chore: update e2e cart helper functions (#12368)
e51c1eb 
Closes #12366
LTiger14 pushed a commit that referenced this issue May 10, 2021
chore: update e2e cart helper functions (#12368)
eff3c1e 
Closes #12366
@LTiger14 LTiger14 mentioned this issue May 10, 2021
Merged
LTiger14 pushed a commit that referenced this issue May 10, 2021
chore: update e2e cart helper functions (#12368) (#12372)
c29024e 
Closes #12366
@Xymmer Xymmer added this to the before-5.0 milestone Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LTiger14 LTiger14

Labels
bug Something isn't working
Projects
None yet
Milestone
before-5.0
Development

Successfully merging a pull request may close this issue.

chore: update e2e helper functions SAP/spartacus
2 participants
@Xymmer @LTiger14