Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/gh 12308 common strict mode #12312

Merged
merged 7 commits into from
May 7, 2021
Merged

Feature/gh 12308 common strict mode #12312

merged 7 commits into from
May 7, 2021

Conversation

ChristophHi
Copy link
Contributor

No description provided.

@ChristophHi ChristophHi temporarily deployed to dev May 6, 2021 06:30 Inactive
@ChristophHi ChristophHi linked an issue May 6, 2021 that may be closed by this pull request
Fix strict mode issues in product-configurator/common entry point #12308
Closed
@cypress
Copy link

cypress bot commented May 6, 2021 •
edited
Loading


Test summary

482 • 0 • 11 • 0 • Flakiness 0

Run details
Project spartacus
Status Passed
Commit 1b3a12d ℹ️
Started May 7, 2021 5:57 AM
Ended May 7, 2021 6:05 AM
Duration 08:03 💡
OS Linux Ubuntu - 18.04
Browser Electron 87

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@ChristophHi ChristophHi temporarily deployed to dev May 7, 2021 05:36 Inactive
@ChristophHi ChristophHi temporarily deployed to dev May 7, 2021 05:45 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2021

Public API changes

✔️ Nothing changed in analyzed entry points.

⚠️ Some entry points are currently impossible to analyze.

Read more
  • @spartacus/asm/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/cart/saved-cart/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/organization/administration/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/organization/order-approval - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/product-configurator/rulebased - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/storefinder/core - ERROR: "import * as ___ from ___;" is not supported yet for local files.
  • @spartacus/storefront - ERROR: The expression contains an import() type, which is not yet supported by API Extractor:
  • @spartacus/user/account/components - ERROR: The expression contains an import() type, which is not yet supported by API Extractor:
  • @spartacus/user/profile/components - ERROR: The expression contains an import() type, which is not yet supported by API Extractor:

💰 How to debug problems?

Read more

Problem with import() type

It happens when type is deduced by TS based on code and at the same time the deduced type is not present in the file.
In this specific case to support api-extractor it's worth to add type declaration explicitly.

Debugging steps:

  • go to the bot action logs
  • find api-extractor logs for broken library
  • check in which file and line the problems exists
  • build the library locally and check content of the file mentioned in logs (look for import()
  • add explicit type to problematic source code
  • build the library once again and verify that the import( is no longer present
  • commit and push the code with defined type

Problem with import * as ___

Api-extractor doesn't support this namespace syntax.
Check if you really need to use namespace in the library. Try to avoid namespaces when possible.

@Larisa-Staroverova Larisa-Staroverova self-requested a review May 7, 2021 07:18
@ChristophHi ChristophHi merged commit c9721cf into develop May 7, 2021
@ChristophHi ChristophHi deleted the feature/GH-12308-common-strict-mode branch May 7, 2021 07:23
@ChristophHi ChristophHi temporarily deployed to dev May 7, 2021 07:23 Inactive
marcinkapica added a commit that referenced this pull request May 11, 2021
@marcinkapica
Merge branch 'develop' into feature/GH-12277
5c6b51f 
* develop: (23 commits)
  fix: remove tabbing focus when using mouse (#12349)
  refactor: Revert previous commit: "Remove checkout dependency in user lib." (#12373)
  chore: update e2e cart helper functions (#12368)
  refactor: Remove checkout dependency in user lib.  (#12307)
  chore: Schematics - improve lib utils to support feature name constants (#12238)
  fix: Fix usage of redirectUri config on SSR (#12364)
  test: refactor product configuration e2e cypress helper and test classes (#12352)
  feat: Add new slot for template definition (#12251)
  fix: Check availability of config form before setting focus (#12342)
  chore: Update schematics + run.sh script (#12344)
  Revert "chore: Update the run.sh script to include saved cart as a general feature-lib instead of only b2b (#12332)" (#12343)
  chore: require successful SSR in the epic release checklist (#12337)
  chore: Fix strict mode issues in common entry point (#12312)
  chore: Update the run.sh script to include saved cart as a general feature-lib instead of only b2b (#12332)
  chore: fix text files using CRLF line endings to use LF (#12325)
  fix: Add cart context check for cart bundle and issue component (#12322)
  fix: Re-enable check for applicable cart context (#12296)
  fix: Provide breakpoint service as mandatory dependency (#12310)
  Revert "chore: TMS migration (#12249)" (#12306)
  fix: Configurator menu should not be displayed twice on screen resize (#12250)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Larisa-Staroverova Larisa-Staroverova Larisa-Staroverova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix strict mode issues in product-configurator/common entry point
2 participants
@ChristophHi @Larisa-Staroverova