fix: add missing role attribute #19870
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spartacus
|
||||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
fix/CXSPA-9015
|
| Run status |
|
| Run duration | 11m 58s |
| Commit |
|
| Committer | sdrozdsap |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Pio-Bar
requested changes
Jan 17, 2025
Comment on lines
180
to
189
| <div aria-live="assertive" aria-atomic="true"> | ||
| <span *ngIf="validationError" tabindex="0" class="cx-invalid-message"> | ||
| <span | ||
| *ngIf="validationError" | ||
| role="alert" | ||
| tabindex="0" | ||
| class="cx-invalid-message" | ||
| > | ||
| {{ validationError | cxTranslate }} | ||
| </span> | ||
| </div> |
There was a problem hiding this comment.
We can remove the aria-live="assertive" aria-atomic="true" since role alert provides the same functionality.
There was a problem hiding this comment.
Since *ngIf and role="alert" doesn't really fit to each other - if we create an element with role alert it is not announced, only when it content changes.
So for that container div has <div aria-live="assertive" aria-atomic="true">. And role alert on the span is just to suppress AMP warnings
There was a problem hiding this comment.
Do you know if there is better way that would work?
petarmarkov9449
approved these changes
Jan 30, 2025
Zeyber
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.