Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update jest setup files to remove warning (CXSPA-9288) #19955

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

kimhw0630
Copy link
Contributor

@kimhw0630 kimhw0630 commented Jan 30, 2025

Closes: https://jira.tools.sap/browse/CXSPA-9288

Notes:

import 'jest-preset-angular/setup-jest';
import 'zone.js';

The above two lines have been replaced in all instances of setup-jest.ts as below

import { setupZoneTestEnv } from 'jest-preset-angular/setup-env/zone';
setupZoneTestEnv();

@kimhw0630 kimhw0630 requested review from a team as code owners January 30, 2025 15:40
@github-actions github-actions bot marked this pull request as draft January 30, 2025 15:40
@kimhw0630 kimhw0630 marked this pull request as ready for review January 30, 2025 15:55
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft January 30, 2025 15:58
@kimhw0630 kimhw0630 marked this pull request as ready for review January 30, 2025 16:09
Copy link

cypress bot commented Jan 30, 2025

spartacus    Run #46925

Run Properties:  status check passed Passed #46925  •  git commit 964850c1e7 ℹ️: Merge f0d2676d7bd82e508a2f09ccc9706bc7a44d4d11 into 53ca163c60e2124d0ef8369d0297...
Project spartacus
Branch Review feat/CXSPA-9288
Run status status check passed Passed #46925
Run duration 11m 49s
Commit git commit 964850c1e7 ℹ️: Merge f0d2676d7bd82e508a2f09ccc9706bc7a44d4d11 into 53ca163c60e2124d0ef8369d0297...
Committer Hak Woo Kim
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link
Contributor

@pawelfras pawelfras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Looks like also import 'zone.js' are no longer required for these particular test configs.
Let's add info to the PR descriptions that such imports were also removed.

@kimhw0630 kimhw0630 merged commit 5e869a6 into develop Jan 31, 2025
28 checks passed
@kimhw0630 kimhw0630 deleted the feat/CXSPA-9288 branch January 31, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants