[FIX] CXSPA-9334 Terms and condition URL not changed accordingly when… #19966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… site language is switched
|
Hello @andreighervan7. I'm not sure if you are familiar with the commit guideline and planned to change the PR title to the commit message that complies with our guidelines. If not, please take a look here https://sap.github.io/spartacus-docs/commit-guidelines/ |
rmch91
requested changes
Feb 5, 2025
There was a problem hiding this comment.
Good job @andreighervan7. Let's improve your solution a little bit.
feature-libs/checkout/base/components/checkout-place-order/checkout-place-order.component.html
Outdated
Show resolved
Hide resolved
feature-libs/checkout/base/components/checkout-place-order/checkout-place-order.component.ts
Outdated
Show resolved
Hide resolved
feature-libs/checkout/base/components/checkout-place-order/checkout-place-order.component.ts
Outdated
Show resolved
Hide resolved
feature-libs/checkout/base/components/checkout-place-order/checkout-place-order.component.ts
Outdated
Show resolved
Hide resolved
feature-libs/checkout/base/components/checkout-place-order/checkout-place-order.component.ts
Outdated
Show resolved
Hide resolved
feature-libs/checkout/base/components/checkout-place-order/checkout-place-order.component.ts
Outdated
Show resolved
Hide resolved
feature-libs/checkout/base/components/checkout-place-order/checkout-place-order.component.ts
Outdated
Show resolved
Hide resolved
feature-libs/checkout/base/components/checkout-progress/checkout-progress.component.html
Outdated
Show resolved
Hide resolved
spartacus
|
||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
feature/CXSPA-9334
|
| Run status |
|
| Run duration | 04m 16s |
| Commit |
|
| Committer | andreighervan7 |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
| View all changes introduced in this branch ↗︎ | |
rmch91
requested changes
Feb 6, 2025
feature-libs/checkout/base/components/checkout-place-order/checkout-place-order.component.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket CXSPA-9334