feat: schematics for guide (2) - modernize-apps-migrated-from-2211.32-to-2211.35.md #19969
+902
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…names - to not be confused by IDE with newer versions of docs in the future migrations
pawelfras
reviewed
Feb 6, 2025
...tics/src/modernize-app-migrated-from-2211_32-to-2211_35/csr-and-ssr/move-assets-to-public.ts
Outdated
Show resolved
Hide resolved
projects/schematics/src/modernize-app-migrated-from-2211_32-to-2211_35/index.ts
Outdated
Show resolved
Hide resolved
...ematics/src/modernize-app-migrated-from-2211_32-to-2211_35/fallback-advice-to-follow-docs.ts
Show resolved
Hide resolved
projects/schematics/src/modernize-app-migrated-from-2211_32-to-2211_35/ssr/update-server-ts.ts
Outdated
Show resolved
Hide resolved
…tacus into kris-schematics--guide2-develop
`loader: (lang: string, chunkName: string) => {`
and
`loader(lang: string, chunkName: string) {`
pawelfras
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
review and QA done. LGTM.
Tested migration agains few different scenarios:
- app migrated from Spartacus 6.8 to 2211.19 then to 2211.35
- app with SSR migrated from Spartacus 6.8 to 2211.19 , then to 2211.35
- app migrated from 2211.19 to 2211.35
- app with SSR migrated from 2211.19 to 2211.35
- assets containing also folders
- translation with/without lazy loading
|
Merged as a partial PR to another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schematics automating the guide https://github.com/SAP/spartacus/blob/develop/docs/migration/2211_35/modernize-apps-migrated-from-2211.32-to-2211.35.md
It's a part 2 of 2 https://jira.tools.sap/browse/CXSPA-9304
QA steps:
create new ng17 app with Spa 2211.19 WITH SSR
migrate it to ng19 and Spa 2211.35.0-1 according to this doc draft https://github.com/SAP/spartacus/blob/develop/docs/migration/2211_35/migration.md
build and publish to verdaccio libraries from this branch
run the migration schematics in the following way (it will be the recommended way for customers:
# Execute separate migration schematic: ng g @spartacus/schematics:modernize-app-migrated-from-2211_32-to-2211_35check the diff of changed files in your app and compare against the changes mentioned in the manual guide: https://github.com/SAP/spartacus/blob/develop/docs/migration/2211_35/modernize-apps-migrated-from-2211.32-to-2211.35.md
repeat everything, but starting with the app with CSR ONLY (no SSR)