Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support VARBINARY for uuids #301

Merged
merged 10 commits into from
Aug 5, 2024
Merged

Support VARBINARY for uuids #301

merged 10 commits into from
Aug 5, 2024

Conversation

kasium
Copy link
Contributor

@kasium kasium commented Aug 2, 2024

No description provided.

@kasium kasium requested a review from jarus August 2, 2024 11:44
@jarus
Copy link
Member

jarus commented Aug 2, 2024

LGTM beside the pending CI verification but I assume that should be gone once #302 has been merged.

Maybe two things for further enhancements:

  1. How about documenting the usage with SAP HANA's NEWUID and SYSUUID?
  2. How about adding another switch use_fastuuid so that SQLAlchemy-HANA returns a fastuuid.UUID object?

@kasium
Copy link
Contributor Author

kasium commented Aug 2, 2024

  1. How about documenting the usage with SAP HANA's NEWUID and SYSUUID?

will do that

  1. How about adding another switch use_fastuuid so that SQLAlchemy-HANA returns a fastuuid.UUID object?

I would prefer a general solution which should be implemented in SQLAlchemy since we just extend the Uuid type. Let me open a discussion there: sqlalchemy/sqlalchemy#11683

@kasium kasium merged commit 25a0adc into main Aug 5, 2024
16 checks passed
@kasium kasium deleted the uuid-binary branch August 5, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants