Skip to content

Commit

Permalink
[INTERNAL] Azure: Disable AVA worker threads
Browse files Browse the repository at this point in the history
This is to workaround for the
"FATAL ERROR: v8::FromJust Maybe value is Nothing." errors we see for
our Windows and macOS test executions on Azure.

The error is sporadic, but most consistently appears on Windows 2022
(Azure image '20230630.1.0' and Node v18.16.1.

avajs/ava#2947 seems to suggest this is a
Node.js issue as reported at nodejs/node#43304

Disabling the use of our own worker threads in minifier.js resolve the
issue. Disabling worker threads in AVA resolves it too.

Since we want to test our worker threads, we opted for the latter by
setting the AVA option '--no-worker-threads' for all scripts executed in
Azure.

All this indicates an issue with using worker threads (or the workerpool
package) from within workers.
  • Loading branch information
RandomByte committed Jul 13, 2023
1 parent fd542df commit ae92853
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,6 @@ steps:
codeCoverageTool: 'cobertura'
summaryFileLocation: '$(System.DefaultWorkingDirectory)/coverage/cobertura-coverage.xml'

- script: npm run coverage
- script: npm run coverage -- --no-worker-threads
displayName: Run Test Natively in Case of Failures
condition: failed()
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"unit": "rimraf test/tmp && ava",
"unit-verbose": "rimraf test/tmp && cross-env UI5_LOG_LVL=verbose ava --verbose --serial",
"unit-watch": "rimraf test/tmp && ava --watch",
"unit-xunit": "rimraf test/tmp && ava --node-arguments=\"--experimental-loader=@istanbuljs/esm-loader-hook\" --tap --timeout=1m | tap-xunit --dontUseCommentsAsTestNames=true > test-results.xml",
"unit-xunit": "rimraf test/tmp && ava --no-worker-threads --node-arguments=\"--experimental-loader=@istanbuljs/esm-loader-hook\" --tap --timeout=1m | tap-xunit --dontUseCommentsAsTestNames=true > test-results.xml",
"unit-inspect": "cross-env UI5_LOG_LVL=verbose ava debug --break",
"coverage": "rimraf test/tmp && nyc ava --node-arguments=\"--experimental-loader=@istanbuljs/esm-loader-hook\"",
"coverage-xunit": "nyc --reporter=text --reporter=text-summary --reporter=cobertura npm run unit-xunit",
Expand Down

0 comments on commit ae92853

Please sign in to comment.