Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: console error #251

Merged
merged 2 commits into from
Aug 30, 2023
Merged

fix: console error #251

merged 2 commits into from
Aug 30, 2023

Conversation

yanaminkova
Copy link
Member

@yanaminkova yanaminkova commented Aug 25, 2023 •
edited
Loading

Fixes: #250, #252

jdichev
jdichev requested changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@jdichev jdichev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can feature check at the beginning of this method and return directly a boolean or an empty object if there is no BaseConfig module.
Something like

if (!BaseConfig) {
  return false;
}

at the beginning of the method

@yanaminkova yanaminkova merged commit 9bfafde into master Aug 30, 2023
3 checks passed
@yanaminkova yanaminkova deleted the toolsapi-fix branch August 30, 2023 08:14
This was referenced Aug 30, 2023
Closed
Closed
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.6.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@yanaminkova yanaminkova mentioned this pull request Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdichev jdichev jdichev approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inspector doesn't work at new version 1.6.2
2 participants
@yanaminkova @jdichev