fix(CommonProps): add type definitions for HTML attributes (#692)

SAP · Sep 25, 2020 · 07c5b6a · 07c5b6a
1 parent 825a629
commit 07c5b6a
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 8 deletions.
diff --git a/packages/main/src/components/AnalyticalTable/index.tsx b/packages/main/src/components/AnalyticalTable/index.tsx
@@ -52,7 +52,7 @@ import { TitleBar } from './TitleBar';
 import { orderByFn } from './util';
 import { VirtualTableBody } from './virtualization/VirtualTableBody';
 
-export interface TableProps extends CommonProps {
+export interface TableProps extends Omit<CommonProps, 'title'> {
   /**
    * Please look at the [AnalyticalTableColumnDefinition interface](#column-properties) for a full list of options.
    */
@@ -213,8 +213,6 @@ const AnalyticalTable: FC<TableProps> = forwardRef((props: TableProps, ref: Ref<
     setColumnOrder,
     dispatch,
     totalColumnsWidth,
-    toggleRowSelected,
-    toggleAllRowsSelected,
     setGroupBy
   } = useTable(
     {

diff --git a/packages/main/src/components/FilterBar/index.tsx b/packages/main/src/components/FilterBar/index.tsx
@@ -275,6 +275,7 @@ const FilterBar: FC<FilterBarPropTypes> = forwardRef((props: FilterBarPropTypes,
             child.props.children?.props?.children?.map((item) => item.props.selected).join(',') !==
               prevChildren?.current?.[child.key]?.children?.map((item) => item.props.selected).join(','))
         ) {
+          // @ts-ignore
           const { [child.key]: omit, ...rest } = dialogRefs;
           setDialogRefs(rest);
         }

diff --git a/packages/main/src/components/FilterItem/index.tsx b/packages/main/src/components/FilterItem/index.tsx
@@ -16,7 +16,7 @@ import React, { FC, forwardRef, ReactNode, RefObject, useEffect, useMemo } from
 import { CommonProps } from '../../interfaces/CommonProps';
 import styles from './FilterItem.jss';
 
-export interface FilterItemPropTypes extends CommonProps {
+export interface FilterItemPropTypes extends Omit<CommonProps, 'onChange'> {
   placeholder?: string;
   type?: FilterType;
   label?: string;

diff --git a/packages/main/src/components/VariantManagement/index.tsx b/packages/main/src/components/VariantManagement/index.tsx
@@ -27,7 +27,8 @@ export interface VariantItem {
   label: string;
 }
 
-export interface VariantManagementPropTypes extends CommonProps {
+
+export interface VariantManagementPropTypes extends Omit<CommonProps, 'onSelect'> {
   /**
    * Determines on which side the VariantManagement popover is placed at.
    */

diff --git a/packages/main/src/interfaces/CommonProps.ts b/packages/main/src/interfaces/CommonProps.ts
@@ -1,6 +1,6 @@
-import { CSSProperties, Ref } from 'react';
+import { CSSProperties, Ref, HTMLAttributes } from 'react';
 
-export interface CommonProps {
+export interface CommonProps extends HTMLAttributes<HTMLElement> {
   /**
    * Element style which will be appended to the most outer element of a component.
    * Use this prop carefully, some css properties might break the component.

diff --git a/packages/main/src/internal/withWebComponent.tsx b/packages/main/src/internal/withWebComponent.tsx
@@ -23,7 +23,7 @@ const createEventPropName = (eventName) => `on${capitalizeFirstLetter(kebabToCam
 
 type EventHandler = (event: CustomEvent<unknown>) => void;
 
-export interface WithWebComponentPropTypes extends CommonProps, HTMLAttributes<HTMLElement> {
+export interface WithWebComponentPropTypes extends CommonProps {
   ref?: Ref<any>;
   children?: any | void;
 }