-
Notifications
You must be signed in to change notification settings - Fork 103
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor(SegmentedButton): Remove visible prop and rename enabled (#125)
BREAKING CHANGE: `SegmentedButtonItem` removed `visible` prop, please use conditional rendering instead BREAKING CHANGE: `SegmentedButton` and `SegmentedButtonItem` prop enabled is now renamed to disabled and logic is inverted [ci skip]
- Loading branch information
1 parent
8f962bf
commit 174447a
Showing
8 changed files
with
217 additions
and
166 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
packages/main/src/components/SegmentedButton/__snapshots__/SegmentedButton.test.tsx.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
// Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
||
exports[`SegmentedButton Update Selection via API 1`] = ` | ||
<ul | ||
class="SegmentedButton--segmentedButton-" | ||
role="radiogroup" | ||
tabindex="0" | ||
> | ||
<li | ||
class="SegmentedButtonItem--segmentedButtonItem- SegmentedButtonItem--focusableItem- SegmentedButtonItem--selected-" | ||
data-has-own-width="false" | ||
> | ||
Test | ||
</li> | ||
<li | ||
class="SegmentedButtonItem--segmentedButtonItem- SegmentedButtonItem--focusableItem-" | ||
data-has-own-width="false" | ||
> | ||
Test | ||
</li> | ||
</ul> | ||
`; | ||
|
||
exports[`SegmentedButton Update Selection via API 2`] = ` | ||
<ul | ||
class="SegmentedButton--segmentedButton-" | ||
role="radiogroup" | ||
tabindex="0" | ||
> | ||
<li | ||
class="SegmentedButtonItem--segmentedButtonItem- SegmentedButtonItem--focusableItem-" | ||
data-has-own-width="false" | ||
> | ||
Test | ||
</li> | ||
<li | ||
class="SegmentedButtonItem--segmentedButtonItem- SegmentedButtonItem--focusableItem- SegmentedButtonItem--selected-" | ||
data-has-own-width="false" | ||
> | ||
Test | ||
</li> | ||
</ul> | ||
`; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.