fix(AnalyticalTable): persist values and don't close the popover when…

… typing within the filters-popover input field (#810)
SAP · Oct 22, 2020 · 45a6d8f · 45a6d8f
1 parent c0fac23
commit 45a6d8f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/packages/main/src/components/AnalyticalTable/ColumnHeader/ColumnHeaderModal.tsx b/packages/main/src/components/AnalyticalTable/ColumnHeader/ColumnHeaderModal.tsx
@@ -120,9 +120,6 @@ export const ColumnHeaderModal = (props: ColumnHeaderModalProperties) => {
     if (open) {
       popoverInstance?.openBy(targetRef.current);
     }
-    return () => {
-      popoverInstance?.close();
-    };
   }, [open, targetRef.current, ref.current]);
 
   const onAfterClose = useCallback(

diff --git a/packages/main/src/components/AnalyticalTable/defaults/FilterComponent/index.tsx b/packages/main/src/components/AnalyticalTable/defaults/FilterComponent/index.tsx
@@ -8,5 +8,5 @@ export const DefaultFilterComponent: FC<any> = ({ column }) => {
     },
     [column.setFilter]
   );
-  return <Input onInput={handleChange}>{column.filterValue}</Input>;
+  return <Input onInput={handleChange} value={column.filterValue} />;
 };