fix(web-components-wrapper): don't generate default props for empty s…

…trings (#469)
SAP · May 4, 2020 · 48505d9 · 48505d9
1 parent b21b1f0
commit 48505d9
Show file tree

Hide file tree

Showing 94 changed files with 193 additions and 1,212 deletions.
diff --git a/packages/main/scripts/create-web-components-wrapper.js b/packages/main/scripts/create-web-components-wrapper.js
@@ -593,7 +593,9 @@ resolvedWebComponents.forEach((componentSpec) => {
 
       propTypes.push(dedent`
     /**
-     * ${property.description}
+     * ${property.description
+       .replace(/\n\n<br><br> /g, '<br/><br/>\n  *\n  * ')
+       .replace(/\n\n/g, '<br/><br/>\n  *\n  * ')}
      */
      ${property.name}?: ${tsType.tsType};
     `);
@@ -603,7 +605,7 @@ resolvedWebComponents.forEach((componentSpec) => {
           defaultProps.push(`${property.name}: ${property.defaultValue === 'true'}`);
         } else if (tsType.isEnum === true) {
           defaultProps.push(`${property.name}: ${tsType.tsType}.${property.defaultValue.replace(/['"]/g, '')}`);
-        } else {
+        } else if (tsType.tsType !== 'string' || (tsType.tsType === 'string' && property.defaultValue !== '""')) {
           defaultProps.push(`${property.name}: ${property.defaultValue}`);
         }
       }

diff --git a/packages/main/src/components/ActionSheet/__snapshots__/ActionSheet.test.tsx.snap b/packages/main/src/components/ActionSheet/__snapshots__/ActionSheet.test.tsx.snap
@@ -3,9 +3,7 @@
 exports[`ActionSheet Render without Crashing 1`] = `
 <ui5-responsive-popover
   class="ActionSheet-actionSheet-0 myCustomClass"
-  header-text=""
   horizontal-align="Center"
-  initial-focus=""
   placement-type="Right"
   vertical-align="Center"
 >
@@ -19,14 +17,12 @@ exports[`ActionSheet Render without Crashing 1`] = `
   <ui5-button
     data-is-action-sheet-button=""
     design="Transparent"
-    icon=""
   >
     Reject
   </ui5-button>
   <ui5-button
     data-is-action-sheet-button=""
     design="Transparent"
-    icon=""
   >
     This is my super long text!
   </ui5-button>
@@ -36,16 +32,13 @@ exports[`ActionSheet Render without Crashing 1`] = `
 exports[`ActionSheet does not crash with other component 1`] = `
 <ui5-responsive-popover
   class="ActionSheet-actionSheet-0"
-  header-text=""
   horizontal-align="Center"
-  initial-focus=""
   placement-type="Right"
   vertical-align="Center"
 >
   <ui5-label
     data-is-action-sheet-button=""
     design="Transparent"
-    for=""
   >
     I should not crash
   </ui5-label>