Skip to content

Commit

Permalink
fix(FilterBar/ObjectPage): add toolbar for making action bars respons…
Browse files Browse the repository at this point in the history
…ive (#546)

Closes #533
  • Loading branch information
Lukas742 authored May 29, 2020
1 parent 7230d8e commit bb0d9d4
Show file tree
Hide file tree
Showing 14 changed files with 553 additions and 370 deletions.
4 changes: 0 additions & 4 deletions packages/main/src/components/FilterBar/FilterBar.jss.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,6 @@ const styles = {
boxShadow: 'none',
flexWrap: 'wrap'
},
vLine: {
borderLeft: '1px solid gray',
paddingLeft: '0.5rem'
},
filterArea: {
display: 'flex',
flexWrap: 'wrap',
Expand Down
6 changes: 4 additions & 2 deletions packages/main/src/components/FilterBar/FilterBar.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { Select } from '@ui5/webcomponents-react/lib/Select';
import { Switch } from '@ui5/webcomponents-react/lib/Switch';
import { VariantManagement } from '@ui5/webcomponents-react/lib/VariantManagement';
import { MultiComboBoxItem } from '@ui5/webcomponents-react/lib/MultiComboBoxItem';
import { Toolbar } from '@ui5/webcomponents-react/lib/Toolbar';
import { mount } from 'enzyme';
import React from 'react';
import { act } from 'react-dom/test-utils';
Expand Down Expand Up @@ -198,7 +199,8 @@ describe('FilterBar', () => {
</FilterGroupItem>
</FilterBar>
);
const openFiltersDialogBtn = wrapper.find('.FilterBar-headerRowRight-0-2-7').childAt(3);
const openFiltersDialogBtn = wrapper.find(Toolbar).find(Button).at(5);

act(() => {
openFiltersDialogBtn.prop('onClick')();
});
Expand Down Expand Up @@ -266,7 +268,7 @@ describe('FilterBar', () => {
);

const filterItemsFB = wrapper.find(FilterGroupItem);
const openFiltersDialogBtn = wrapper.find('.FilterBar-headerRowRight-0-2-7').childAt(3);
const openFiltersDialogBtn = wrapper.find(Toolbar).find(Button).at(3);
act(() => {
openFiltersDialogBtn.prop('onClick')();
});
Expand Down
Loading

0 comments on commit bb0d9d4

Please sign in to comment.