update button styling

SAP · Jun 5, 2020 · bf8228e · bf8228e
1 parent 72723f3
commit bf8228e
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 18 deletions.
diff --git a/packages/main/src/components/MessageBox/MessageBox.jss.ts b/packages/main/src/components/MessageBox/MessageBox.jss.ts
@@ -63,7 +63,8 @@ const style = {
       margin: '0 0.25rem'
     },
     '& > ui5-button': {
-      display: 'flex'
+      display: 'flex',
+      minWidth: '4rem'
     }
   }
 };

diff --git a/packages/main/src/components/MessageBox/__snapshots__/MessageBox.test.tsx.snap b/packages/main/src/components/MessageBox/__snapshots__/MessageBox.test.tsx.snap
@@ -25,14 +25,12 @@ exports[`MessageBox Confirm - Cancel 1`] = `
     <ui5-button
       data-action="OK"
       design="Emphasized"
-      style="min-width: 4rem;"
     >
       OK
     </ui5-button>
     <ui5-button
       data-action="Cancel"
       design="Transparent"
-      style="min-width: 4rem;"
     >
       Cancel
     </ui5-button>
@@ -70,14 +68,12 @@ exports[`MessageBox Confirm - OK 1`] = `
     <ui5-button
       data-action="OK"
       design="Emphasized"
-      style="min-width: 4rem;"
     >
       OK
     </ui5-button>
     <ui5-button
       data-action="Cancel"
       design="Transparent"
-      style="min-width: 4rem;"
     >
       Cancel
     </ui5-button>
@@ -115,7 +111,6 @@ exports[`MessageBox Error 1`] = `
     <ui5-button
       data-action="Close"
       design="Emphasized"
-      style="min-width: 4rem;"
     >
       Close
     </ui5-button>
@@ -153,7 +148,6 @@ exports[`MessageBox Information 1`] = `
     <ui5-button
       data-action="OK"
       design="Emphasized"
-      style="min-width: 4rem;"
     >
       OK
     </ui5-button>
@@ -191,14 +185,12 @@ exports[`MessageBox No Title 1`] = `
     <ui5-button
       data-action="OK"
       design="Emphasized"
-      style="min-width: 4rem;"
     >
       OK
     </ui5-button>
     <ui5-button
       data-action="Cancel"
       design="Transparent"
-      style="min-width: 4rem;"
     >
       Cancel
     </ui5-button>
@@ -234,7 +226,6 @@ exports[`MessageBox Not open 1`] = `
     <ui5-button
       data-action="OK"
       design="Emphasized"
-      style="min-width: 4rem;"
     >
       OK
     </ui5-button>
@@ -272,14 +263,12 @@ exports[`MessageBox Show 1`] = `
     <ui5-button
       data-action="Yes"
       design="Emphasized"
-      style="min-width: 4rem;"
     >
       Yes
     </ui5-button>
     <ui5-button
       data-action="No"
       design="Transparent"
-      style="min-width: 4rem;"
     >
       No
     </ui5-button>
@@ -317,7 +306,6 @@ exports[`MessageBox Success 1`] = `
     <ui5-button
       data-action="OK"
       design="Emphasized"
-      style="min-width: 4rem;"
     >
       OK
     </ui5-button>
@@ -355,7 +343,6 @@ exports[`MessageBox Success w/ custom title 1`] = `
     <ui5-button
       data-action="OK"
       design="Emphasized"
-      style="min-width: 4rem;"
     >
       OK
     </ui5-button>
@@ -393,7 +380,6 @@ exports[`MessageBox Warning 1`] = `
     <ui5-button
       data-action="OK"
       design="Emphasized"
-      style="min-width: 4rem;"
     >
       OK
     </ui5-button>

diff --git a/packages/main/src/components/MessageBox/index.tsx b/packages/main/src/components/MessageBox/index.tsx
@@ -192,9 +192,6 @@ const MessageBox: FC<MessageBoxPropTypes> = forwardRef((props: MessageBoxPropTyp
           {actionsToRender.map((action, index) => {
             return (
               <Button
-                style={{
-                  minWidth: '4rem'
-                }}
                 key={action}
                 design={index === 0 ? ButtonDesign.Emphasized : ButtonDesign.Transparent}
                 onClick={handleOnClose}